search

owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.77k stars 3.05k forks source link

[FIX] Some crashes in 4.2.0 (Play Store) #4323

Closed JuancaG05 closed 4 months ago

JuancaG05 commented 4 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4318

QA

JuancaG05 commented 4 months ago

Referencing the different crashes listed in the issue:

  1. This one should be solved. It can be tested by creating the ReceiveExternalFilesActivity (when sharing with ownCloud from other app) and seeing if it shows the correct view (list of spaces in case it is oCIS, root folder of the correct account in case it is oC10...).
  2. This one is a more complex one because it deals with some not common race conditions. I added an additional safety layer to avoid this exception. It seems the main occurrences for this crash happen when navigating to the Shares/Shared by link and Av. offline tabs, so it can be tested by checking everything is correct when navigating to those tabs (no crash, correct folder and files shown...). Anyway, not common occurrences, so could be difficult to reproduce...
  3. This is happening in database migration for users that come from app versions with database older than version 27 (April 2019). We're in database version 44 right now. I don't think solving this is worth it, but if you think it is, just tell me and I'll take a deeper look 🤠.
  4. Shouldn't happen if the device is minimally performant, since it happens when replacing fragments on screen. I did nothing to handle this as it is not so frequent (just 3 occurrences since the release is out), but could be checked in future releases if it continues happening. In any case, this is happening when we go to the details screen and the file cannot be loaded for some reason, which shouldn't happen, and that's why they are just punctual cases.
  5. I proceeded more or less the same as in crash number 2, so that it has an additional layer of safety now. This one seems to occur when we create the FolderPickerActivity (the folder selector) when we want to choose a folder for the camera uploads, so tests could go that direction as well.
jesmrec commented 4 months ago

Thanks for the tips @JuancaG05. Some basic checks performed over:

in oC10 and oCIS accounts

I did not notice changes in the expected behaviour. Let's move this one to 4.2.1