owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.77k stars 3.05k forks source link

[FEATURE REQUEST] Make automatic discovery of the account #4325

Closed Aitorbp closed 4 months ago

Aitorbp commented 4 months ago

Related Issues

App:https://github.com/owncloud/android/issues/4301

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.3/Discovery.md

Some regards: https://github.com/owncloud/android/pull/4325#issuecomment-1982771824

jesmrec commented 4 months ago

It seems that the branch is conflicting with the current master, could you take a look?

jesmrec commented 4 months ago

Feature works fine but is not good-performant. The process to discover is the same as before (so, correct) but the complete discovery in accounts with great amount of folders is pretty slow. Just an example

Account with:

~13.000 folders +20.000 files

took longer than 3 hours to be completely discovered. As first approach is OK, because the given example is just an extreme one to test the app. But, probably, there are other ways to do this task in a more optimal way like depth infinity (needs server logic as well).

Other feature (not a bug): If server connection is lost somehow during the discovery process, this is never completed and there is no way to retry/trigger it because of the removal of the circled arrow icon. Known restriction not to forget.

Finally we have a kind of feature-loss. Before, users could sync the account whenever they wanted, now, only posible in first login. That is a known restriction as well.

jesmrec commented 4 months ago

Let's move this forward, without forgetting the known restrictions