owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.77k stars 3.08k forks source link

[FEATURE REQUEST] Manual removal of local storage #4334

Closed Aitorbp closed 3 months ago

Aitorbp commented 4 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4174


QA

checks performed: https://github.com/owncloud/android/pull/4334#issuecomment-2029357397

Reports:

jesmrec commented 3 months ago

Let's QA this one...

jesmrec commented 3 months ago

QA checks:

jesmrec commented 3 months ago

(1) [FIXED]

We have lost the layout adaption for long strings. Is this a regression?:

Screenshot 2024-04-01 at 10 06 03

Pixel 2, Android 11 725873470

jesmrec commented 3 months ago

(2) [WONT FIX]

i don't want to look crazy, but the new icon looks like a brush more than a broom, not sure how clear it will be for users. This is how it looks like, any better idea @tbsbdr?:

Screenshot 2024-04-01 at 10 15 54
tbsbdr commented 3 months ago

as suggested by you: lets stick to the icon you suggested for now and show a dialog to that the user gets reassured within the text dialog, what will happen if he/she proceeds.

my perspective is, this icon is just a temporary solution because we don't have a better one as of now.

For the future, I can also think about using a "drawer menu" like you suggested and already made for files. This could be a better way to add more actions because we can fit more in it. In a drawer, we can also put in some text to explain what the icons mean.

Drawer example from material design

image

jesmrec commented 3 months ago

So, the brush-broom icon will be the first approach. We'll work in future improvements

jesmrec commented 3 months ago

Approved on my side