[BUG] Retried successful uploads don't free space in /tmp folder

[Aitorbp]

Related Issues

App:https://github.com/owncloud/android/issues/4335

• [x] Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• [x] Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

Checks:

https://github.com/owncloud/android/pull/4341#issuecomment-2031220510

Test Matrix:

https://github.com/owncloud/android/pull/4341#issuecomment-2032537031

Reports:

• [X] (1) keep behaviour in auto-uploads does not remove the files in 2nd try https://github.com/owncloud/android/pull/4341#issuecomment-2031266161 [FIXED]

[jesmrec]

QA checks:

• [X] Upload success at the first try -> /tmp cleaned up
• [X] Upload success at the second try -> /tmp cleaned up
• [X] Upload success at the third try -> /tmp cleaned up
• [x] Upload from camera: nothing in /tmp (check behaviour before)
• [X] Upload from 3rd party app: saved in /tmp and resumed from there (1st and sucessive tries)
• [x] Upload from auto uploads (keep)
• [X] Upload from auto uploads (move)

[jesmrec]

(1) [FIXED]

1. Enable auto uploads and fill up all the fields
2. Select kept in original folder in Original file will be
3. Take same pictures from camera
4. Switch server off (or any other condition that makes upload file, except removing device connection)
5. Wait 15 minutes till uploads are enqueued (check in uploads view)
6. When uploads are enqueued and failed, switch server on (or recover the condition that made them fail)
7. Retry all

Current:

When all uploads are finished after the 2nd try, the /tmp folder contains all the uploaded files. They are not removed.

Expected:

After the 2nd try with success, all files are removed from the /tmp folder

Pixel 2 Android11 Galaxy Tab A8, Android 13 8cba150e0

[jesmrec]

1st try success ✅	1st try fail :x: 2nd try success ✅	1st & 2nd try fail ❌ 3rd try success ✅
Manual uploads	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅
3rd party app upload	Result: ✅ /tmp: ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅
Auto upload (keep)	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅
Auto upload (move)	Result: ✅ /tmp: cleaned up ✅ Device: Files removed ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files removed ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files removed ✅
Picture Upload from Camera	Result: ✅ /tmp: clean ✅ Device: not in device ✅	Result: ✅ /tmp: clean ✅ Device: not in device ✅	Result: ✅ /tmp: clean ✅ Device: not in device ✅
Documents provider (new)	Result: ✅ /tmp: cleaned up ✅ Device: not in device ✅	Result: ✅ /tmp: cleaned up ✅ Device: not in device ✅	Result: ✅ /tmp: cleaned up ✅ Device: not in device ✅
Documents provider (from other provider - copy)	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files kept ✅
Documents provider (from other provider - move)	Result: ✅ /tmp: cleaned up ✅ Device: Files removed ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files removed ✅	Result: ✅ /tmp: cleaned up ✅ Device: Files removed ✅

Some notes about how uploads work:

• When something is going to be uploaded, is first copied/moved to /tmp inside the internal storage and pushed to the server from there. There is one exception: picture uploads. In this case, the picture is not copied to /tmp (probably it stays in memory) before being pushed to the server

• For auto uploads with move behaviour (removing local copy), in the moment the files are moved to /tmp, they are removed from local storage. In case of a release build, pictures and videos are not reachable anymore in case some strange failure happens. I'd add some kind of warning if user chooses this option . Is this feasible @Aitorbp @JuancaG05 @joragua ? (to address in another issue), wdyt?

• For "from document provider": copy and move options make the same effect in the app (one uploaad). Just to keep consistency with the other cases, i tested also the move operation in the doc. provider.

[jesmrec]

Approved on my side

Take the chart above as reference of the uploads behaviour in reference to the internal storage.