owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.82k stars 3.05k forks source link

[FEATURE REQUEST] Improvements in remove confirmation dialog #4342

Closed JuancaG05 closed 5 months ago

JuancaG05 commented 6 months ago

Is your feature request related to a problem? Please describe. The remove confirmation dialog is currently pretty simple, and could be improved by showing some valuable information (being aware of not overloading the dialog, that's not the aim).

Describe the solution you'd like I think it would be nice to apply 2 different improvements:

  1. When removing a file with thumbnail, it would be cool to show the thumbnail in the dialog to know exactly which file we are going to delete (also to avoid misclicks). Currently, we just show the title, which can be non-descriptive sometimes:
  1. When removing several files, it would be nice to show the number of elements selected. Currently, we show a common message for every case. It's true that there's a conflictive case, in which we select a folder: should we consider it as just 1 element or count recursively all the elements contained there? Right now it looks like this:

Describe alternatives you've considered Proposals are welcome, and more ideas or suggestions as well 🙂.

TASKS

jesmrec commented 6 months ago

When removing an image, it would be cool to show the thumbnail in the dialog to know exactly which image we are going to delete (also to avoid misclicks). Currently, we just show the title, which can be non-descriptive sometimes:

Should we show everything that contains a thumbnail? for example a txt file, not only an image. If we are ready for this, app will be ready to show any supported thumbnail in the future.

JuancaG05 commented 6 months ago

Should we show everything that contains a thumbnail? for example a txt file, not only an image. If we are ready for this, app will be ready to show any supported thumbnail in the future.

Sure! I didn't realise about them. I'll update the main comment, thanks 😄