owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.77k stars 3.08k forks source link

[FEATURE REQUEST] Improvements in remove confirmation dialog #4348

Closed joragua closed 2 months ago

joragua commented 3 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4342


QA

jesmrec commented 2 months ago

Some QA checks

jesmrec commented 2 months ago

Feature is functionally correct.

Just one detail: our convention is that every PR has to contain only two calens' commits: one for our input and another one from the calens job. In this PR, there are three commits, one of them should be removed (good chance to play with interactive rebase)

joragua commented 2 months ago

Feature is functionally correct.

Just one detail: our convention is that every PR has to contain only two calens' commits: one for our input and another one from the calens job. In this PR, there are three commits, one of them should be removed (good chance to play with interactive rebase)

Ok, I removed those calens' commits with interactive rebase and now it should be ready. 😃

jesmrec commented 2 months ago

great! then is totally correct and approved!