Closed joragua closed 2 months ago
Some QA checks
Feature is functionally correct.
Just one detail: our convention is that every PR has to contain only two calens' commits: one for our input and another one from the calens job. In this PR, there are three commits, one of them should be removed (good chance to play with interactive rebase)
Feature is functionally correct.
Just one detail: our convention is that every PR has to contain only two calens' commits: one for our input and another one from the calens job. In this PR, there are three commits, one of them should be removed (good chance to play with interactive rebase)
Ok, I removed those calens' commits with interactive rebase and now it should be ready. 😃
great! then is totally correct and approved!
Related Issues
App: https://github.com/owncloud/android/issues/4342
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA