[BUG] "Clear data" button malfunctioning

[Aitorbp]

Related Issues

App: https://github.com/owncloud/android/issues/4309

• [x] Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• [x] Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

Reports:

• [X] (1) Accounts removed in migration https://github.com/owncloud/android/pull/4350#issuecomment-2031686479

Final behaviour:

https://github.com/owncloud/android/pull/4350#issuecomment-2036919590

[jesmrec]

About the removed translations, i think that removing the original string from setup.xml , transifex will remove it from all translation files... i'm not totally sure about this, any further idea?

[jesmrec]

(1) [FIXED]

The solution is based in a preference PREFERENCE_CLEAR_DATA_ALREADY_TRIGGERED which existence deals some actions, f. ex. removing the existent accounts. The problem comes with the migrations. The preference did not exist in advance, therefore when migration takes part, the accounts are going to be removed. That's not expected and must be fixed.

[jesmrec]

OTOH, it'd be useful to detail in the issue the last status update. Last comment is about suggesting the account removal, but not the final decision and why.

[jesmrec]

Checks performed:

• [X] Clear data with accounts in device: data cleaned up and accounts removed when app is reopen (not before)
• [X] Clear data with no accounts in device

Migrations:

Release mode: required change in version code, otherwise everything removed. We can assume that for release builds. Debug mode: works only for versions starting from this (containing the version code inside the shared preferences)

Go on with this. Will need another check in the release process.