Improve av. offline performance

Aitorbp commented 3 months ago

[x] Add changelog files for the fixed issues in folder changelog/unreleased. More info here
[x] Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Checks:

Reports:

[x] (1) Av. offline does not sync https://github.com/owncloud/android/pull/4354#issuecomment-2045170517 [FIXED]
[x] (2) Adding external files to av. offline does not trigger a sync https://github.com/owncloud/android/pull/4354#issuecomment-2046659982 [FIXED]
[x] (3) Local changes not pushed https://github.com/owncloud/android/pull/4354#issuecomment-2047280691 [FIXED]

jesmrec commented 2 months ago

QA checks:

Feature:

[X] Av offline file with no modification -> not synced
[X] Av offline file with local modification -> synced
[x] Av offline file with external modification -> synced
[X] Av offline folder with no modification -> not synced
[X] Av offline folder with local modification -> synced
- [X] add new file inside -> not synced till manual update (improve?) not regression
- [X] modify file inside
[X] Av offline folder with external modification -> synced
- [X] add new file inside
- [X] remove existing file inside
- [X] modify existing file inside

Regressive sync use cases

[x] When we try to choose the destination path where to make an auto-upload
[x] When we copy a file, we choose the space, it makes a sync of the content.
[x] When we do a move operation
[x] When we open the application
[x] When we click on set available offline on a folder/file in the operations menu
[X] When we click on unset available offline on a folder/file in the operations menu -> NA
[x] When switching accounts
[x] When clicking on synchronize in the operations list -> improvement: show snackbar in av. offline
[x] When entering a folder
[x] When exiting the folder, by clicking on back
[x] When cancelling a copy/move file operation
[x] When triggering the AccountDiscoveryWorker worker
[x] When the AvailableOfflinePeriodicWorker is activated, the files that are available offline are synchronised.
[x] When we receive an external file and we choose the destination place.

jesmrec commented 2 months ago

(1) [FIXED]

Check the following steps out. We are losing the sync condition in the basic av. offline case.

Create a folder and add some files inside (better images)
Set the folder as av. offline (without browsing inside)
Wait till everything download
Unset the folder as available offline
Remove locally the content of the folder
Repeat step 2.
After some seconds, remove device connection
Browse into the folder and click on any file

Current: not posible to preview

Expected: file displayed. It is available offline, so the preview must be always available. When the folder was set as av. offline in step 2. all content inside had to be synced. It doesn't

Pixel 2 Android 11 d86367b9c

Aitorbp commented 2 months ago

(1)

Check the following steps out. We are losing the sync condition in the basic av. offline case.

Create a folder and add some files inside (better images)

Set the folder as av. offline (without browsing inside)

Wait till everything download

Unset the folder as available offline

Remove locally the content of the folder

Repeat step 2.

After some seconds, remove device connection

Browse into the folder and click on any file

Current: not posible to preview

Expected: file displayed. It is available offline, so the preview must be always available. When the folder was set as av. offline in step 2. all content inside had to be synced. It doesn't

Pixel 2 Android 11 d86367b9c

With the change of refresh functionality, from now on only files that have been modified will be returned. This means that the local etag and the server etag are different. With this known, we are presented with the case discovered by @jesmrec.

This means if we delete the local copy and we want to make a set available offline, it will compare between two equal etags, as the file on the server has not changed and the local etag has remained as it was before deleting it.

So the condition has not detected that there was a change if we make the files available offline after deleting the content of the folder locally. This means that the download is not done even if it is available offline. If we take the connection offline and enter a file it will not be available.

So to solve this we must set the etag parameter to null if we want to delete files locally. This way, they will be downloaded again.

jesmrec commented 2 months ago

(2) [FIXED]

may be related with (1)

Set a folder as av. offline
Using other client, web f. ex., add more files to the folder
In app, pull to refresh (not browsing inside)
Remove device connection
Try to open the file added in 2.

Current: file not opened

Expected: file should be opened. Pull to refresh action should trigger a sync in the av. offline folder because the etag changed after new item was added inside.

Pixel 2 Android 11 b1cad6fb

jesmrec commented 2 months ago

(3) [FIXED]

Set a folder as av. offline
Modify any file inside the folder using the open with option (i used a txt file with the quickedit free editor)
Save modifications in external editor
Go again to the app

Current: changes are not synced back to the server. Even pulling to refresh, changes not pushed

Expected: just entering the to the containing folder, changes are synced back to the server (checked current master)

Pixel 2 Android 11 d75ebeae0

jesmrec commented 2 months ago

Go ahead with this! approved.

owncloud / android