search

owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.77k stars 3.08k forks source link

[RELEASE] 4.3.0 #4359

Closed jesmrec closed 6 days ago

jesmrec commented 3 months ago

Open Release

TASKS:

QA

Regression test: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.3/RegressionTest.md

Bugs & improvements:

jesmrec commented 2 weeks ago

(1) [FIXED]

  1. Create a shortcut
  2. Open Details view of the shortcut

Current: icon is incorrect Expected: shortcuts icon there

jesmrec commented 1 week ago

(2) [FIXED]

About the release notes. The list of items is sorted by the merging date, but that order might not be interesting for the user. I'd set the main features on the top and sorted by importante/relevance

For example (open to discussion):

(those are the main news)

(those are improvements with less impact)

and then, the bug fixes and others.

This is just an example, the important is the idea about how to sort the entries there

mmattel commented 1 week ago

About the release notes. ... I'd set the main features on the top and sorted by importante/relevance

That should also go into the release notes we have in docs-main in the android release notes section. Helping hands next week if I have infos you can reference 😄

jesmrec commented 1 week ago

(3) [WONT FIX]

Creating a shortcut in oC10 account, the icon is not the proper one:

Screenshot 2024-06-25 at 18 45 36

jesmrec commented 1 week ago

That should also go into the release notes we have in docs-main in the android release notes section. Helping hands next week if I have infos you can reference 😄

We can post the list somewhere, let us know and will send the list (now only visible in the app itself). I guess that the technical changelog does not fit that documentation, right @mmattel ?

Aitorbp commented 1 week ago

(3)

Creating a shortcut in oC10 account, the icon is not the proper one:

Screenshot 2024-06-25 at 18 45 36

Regarding this report, in OC10 we are not receiving the mimetype of the shortcuts correctly. We should receive a text/uri-list type, as in OCIS, but instead we receive application/octet-stream , which is the value that is set by default. To choose the icon we always use the mimetype, except in the case of transfers, which do not have a mimetype and we have to trust the extension of the file. Only in this case if we receive the icon correctly. As a conclusion, I would not change anything in the code, since it is the server's responsibility to bring us this data correctly. What do you think? @JuancaG05 @jesmrec

jesmrec commented 1 week ago

If the server returns an "incorrect" mimetype, we have to live with it. I wouldn't play with the extension amap. In fact, i'd re-check at some point the use of the extension in the transfers, in order to unify criteria and avoid that same file could show two different icons.

Aitorbp commented 1 week ago

If the server returns an "incorrect" mimetype, we have to live with it. I wouldn't play with the extension amap. In fact, i'd re-check at some point the use of the extension in the transfers, in order to unify criteria and avoid that same file could show two different icons.

The problem is transfer object doesn't have mimetype, because of that we use the extension in this case. Reports 1 and 2 should be fixed. @jesmrec

jesmrec commented 1 week ago

(1) is fixed (2) is not fixed. The order to show in the release notes comes from the order in the ViewModel, not from the order in the resources' files. (3) is wont fix ftm

Aitorbp commented 1 week ago

(1) is fixed (2) is not fixed. The order to show in the release notes comes from the order in the ViewModel, not from the order in the resources' files. (3) is wont fix ftm

@jesmrec I think now is fixed the report (2)

jesmrec commented 1 week ago

(2) fixed now

jesmrec commented 1 week ago

QA is finished.

Commit approved: 573707a97

Android Studio version: Android Studio Iguana | 2023.2.1 Patch 1

Devices:

Test reports:

Great job, team 💯