owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.76k stars 3.09k forks source link

[BUG] Fix display name truncation issue with ellipsis #4380

Closed Prakhar1701 closed 2 months ago

Prakhar1701 commented 2 months ago

Resolved the bug where long display names were truncated incorrectly in the Manage Accounts view. Now, display names are properly truncated in the middle with ellipsis (...) to maintain readability.

Fixes #4351

Related Issues

App:


QA

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

jesmrec commented 2 months ago

Thanks a lot for you contribution @Prakhar1701. Now, the team will review it and give you some feedback from code and QA points of view.

Prakhar1701 commented 2 months ago

@JuancaG05 I have added the Calens file and the release note, please check.

Prakhar1701 commented 2 months ago

Thanks @JuancaG05 for guiding me with the correct format of the files. I have made the required changes, please check.

jesmrec commented 2 months ago

Let's QA this

jesmrec commented 2 months ago

(1) [FIXED]

I notice that the text is not adapting somehow to the existing room. For example, this user:

Screenshot 2024-04-15 at 12 43 02

It is shown correctly in portrait orientation:

Screenshot 2024-04-15 at 12 44 03

but, in landscape:

Screenshot 2024-04-15 at 12 44 44

the circled area in white gives enough room to show more information.

Could you take a look?

Pixel2, Android11 13da2792

Prakhar1701 commented 2 months ago

@jesmrec I have resolved the mentioned issue, please check.

jesmrec commented 2 months ago

Fixed, thanks @Prakhar1701 !

jesmrec commented 2 months ago

Let's move this forward. Approved