[a11y] 11.1.1.1a Non-text content (control elements)

[Aitorbp]

Related Issues

App: https://github.com/owncloud/android/issues/4360

• [x] Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• [x] Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

[jesmrec]

QA checks

Personal space

• [X] Several control elements (buttons) have been detected on the page, that do not have an alternative text.
  • [X] Hamburger button
  • [X] Search button
  • [X] Grid/list view
  • [X] Fab button
  • [X] Manage accounts button
  • [x] 3-dot-button

Back in navigation

Menu

• [X] Logo

Share

• [X] Several control elements (buttons) have been detected on the page, that have no alternative text.
  • [X] Private link
  • [X] Delete share
  • [X] Edit share
  • [X] Share link
  • [X] Delete link
  • [X] Edit link
  • [x] Back button

Spaces

• [X] Menu button
• [X] Manage accounts button

Manage accounts

• [X] Several control elements (buttons) have been detected on the page, that have no alternative text.
  • [X] Key button -> OUT -> but in charge, the broom icon is not labelled
  • [X] Trashbin
  • [X] Back button -> back

Image viewer

• [X] Back button -> back

[jesmrec]

Some comments / improvements from my side regarding this PR:

• Probably out of the scope here, but one of the most important buttons in the file list does not have label and was not reported because the report was done before the button: the three-dot-button in the file cell. Is it posible to add there a "actions" label or similar (including the name of the file it would be outstanding)?. As i wrote, not mandatory here, but desirable.

• In the Manage accounts view, we were reported the key icon that does not exist anymore. In charge, we have the new broom icon, i'd set the label instead because it's currently unlabelled. "Clean account" as candidate

• About the "Back" button. I notice different dictations for the same action:

  • In list of files: "Back" ❌
  • In Manage Accounts: "Back" ✅
  • In share view: "Navigate up" ❌
  • In previews: "Back" ✅
  • In Details: "Back" ✅

From my point of view, "Navigate up" means the directory navigation through the structure, moving to the parent folder. Up means "above" and it would make more sense to use "Navigate up" in the list of files. Therefore, the "Back" label for the share view makes more sense and is alligned with the previews and manage accounts' "Back". I guess that there is some logical binding from the UI element in different views, using the same dictation and the solution can become not trivial.

Share your thoughs as well @JuancaG05 @joragua

[JuancaG05]

• Probably out of the scope here, but one of the most important buttons in the file list does not have label and was not reported because the report was done before the button: the three-dot-button in the file cell. Is it posible to add there a "actions" label or similar (including the name of the file it would be outstanding)?. As i wrote, not mandatory here, but desirable.

Yes, I think that would be nice, and that way we will be prepared once they ask for it 👍

• In the Manage accounts view, we were reported the key icon that does not exist anymore. In charge, we have the new broom icon, i'd set the label instead because it's currently unlabelled. "Clean account" as candidate

Makes sense, I would go for "Clean account storage" instead just not to confuse it with a removal of the account (I think it could sound the same for non-expert users)

• About the "Back" button. I notice different dictations for the same action:

  • In list of files: "Back" ❌
  • In Manage Accounts: "Back" ✅
  • In share view: "Navigate up" ❌
  • In previews: "Back" ✅
  • In Details: "Back" ✅

From my point of view, "Navigate up" means the directory navigation through the structure, moving to the parent folder. Up means "above" and it would make more sense to use "Navigate up" in the list of files. Therefore, the "Back" label for the share view makes more sense and is alligned with the previews and manage accounts' "Back". I guess that there is some logical binding from the UI element in different views, using the same dictation and the solution can become not trivial.

Exactly, for the moment, just to avoid logical complexity, we can set it to "Back" always (it works for "going back to the previous screen" but also for "going back to the parent folder", IMO)

[Aitorbp]

Could you review @JuancaG05 the new changes?

[jesmrec]

Everything OK from here!