owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.76k stars 3.09k forks source link

[FEATURE REQUEST] Show app provider icon from endpoint #4391

Closed Aitorbp closed 1 month ago

Aitorbp commented 2 months ago

Related Issues

App:https://github.com/owncloud/android/issues/4105


QA

Aitorbp commented 2 months ago

In relation to this pull request, I share a screenshot of what it would look like with the new changes. The problem I see here is that the icon image that we get from the server (.ico) is not high resolution and is not vectorized. This causes some icons to look a little blurry in the menu. Take a closer look at the purple icon. show_app_provider_icons_from_server

These are the urls of the icons we receive from the server in this example: https://collabora.ocis-wopi.latest.owncloud.works/favicon.ico https://onlyoffice.ocis-wopi.latest.owncloud.works/web-apps/apps/documenteditor/main/resources/img/favicon.ico

jesmrec commented 1 month ago

That's OK for me.