owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.76k stars 3.09k forks source link

[FEATURE REQUEST] Add search functionality to spaces list #4393

Closed joragua closed 2 months ago

joragua commented 2 months ago

Related Issues

App:


QA

jesmrec commented 2 months ago

The calens entry of the current PR should overwrite the entry https://github.com/owncloud/android/issues/4311. With the work done here, that other one is out of scope and its meaning is the opposite.

jesmrec commented 2 months ago

QA checks:

jesmrec commented 2 months ago

I noticed that the spaces' thumbnails mixed after closing the searching option. Something related with recycler list?

Given the following list of spaces in server:

Screenshot 2024-04-29 at 14 46 09

Check the following videos out:

https://github.com/owncloud/android/assets/14894746/d6161a10-e8ed-4a63-8439-487bba945e7a

https://github.com/owncloud/android/assets/14894746/f3725e39-ed1d-4ff1-9d8c-c8c93f0e3fc1

first video: the space called New space show a repeated thumbnail, whereas it doesn't have any thumbnail second video: the space called New space show a repeated thumbnail, whereas it doesn't have any thumbnail

it's like a glitch that can create some hassle

could you take a look?

joragua commented 2 months ago

The problem was that the image of New space couldn't load correctly because it was setting the image of the space that it was previously in the same position in RecyclerView. The solution here is reset the element with dispose() before setting the default image. I've fixed it and now it should work. ✅

Also I removed calens file about https://github.com/owncloud/android/issues/4311

jesmrec commented 2 months ago

Glitch is fixed. This is ready to go 🚀