owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.76k stars 3.09k forks source link

[TECHNICAL] Rely on `R` permission and ignore `resharing` capability for oCIS accounts #4397

Open JuancaG05 opened 2 months ago

JuancaG05 commented 2 months ago

Currently, to know whether we should show the share button or not, we rely on the R permission of the file AND the resharing capability. The resharing capability has been set to false by default in oCIS servers (https://github.com/owncloud/ocis/issues/8842), so we shouldn't look at it anymore. There can be the case in which some files in the Shares space come with the R permission, but none of them should be resharable. So, several acceptance criteria here:

TASKS

TheOneRing commented 2 months ago

Correction: The code enabling resharing for the share jail was removed. The capability will always be false. Our main concern is to disable resharing for the sharejail in any case. Files in the sharejail might provide the R permission but we should never offer the option to share them.

jesmrec commented 2 months ago

iOS related: https://github.com/owncloud/ios-app/issues/1353