owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.84k stars 3.05k forks source link

[FEATURE REQUEST] Quota improvements from GraphAPI #4411

Open jesmrec opened 5 months ago

jesmrec commented 5 months ago

That comes from https://github.com/owncloud/android/pull/4401#issuecomment-2122995186

Some improvements we could add, taking advantage of GraphAPI:

 "quota": {
                "remaining": 0,
                "state": "exceeded",
                "total": 1000000000,
                "used": 1423007244
            },

playing with colors depending on the status is another option (normal, nearing, exceeded)

They could trigger a new request to update the values

TASKS

jesmrec commented 1 month ago

Put an eye on https://github.com/owncloud/enterprise/issues/5808

Could be another fix/improvement to do.

joragua commented 3 weeks ago

EXCEEDED QUOTA

When the quota is exceeded, the progress bar looks:

Captura de pantalla 2024-10-08 a las 14 05 13 (2)

NEARING QUOTA

I don't know how to display the quota when the state is nearing. Now, we have the total and the used with the progress bar. In my opinion, in this case, we can replace the color by yellow/orange or something like that, but change the string I don't think it's a good idea.

@jesmrec @JuancaG05 Take a look and comment if you have more ideas 🚀

jesmrec commented 3 weeks ago

Adding a (nearing) clarification is a good idea?. Just as an idea, we could have three rows:

1st row: progress bar 2nd row: total / used (if used exist). Just this numerical values 3rd row: message

The message is something like:

if exceeded -> The quota is exceeded if nearing -> Close to the limit (or similar) ...

if no message, the 3rd row is gone

What do you think?

joragua commented 3 weeks ago

Yeah, I agree with you. I'll continue with your idea and I'll update the screenshots when it's "finished" 😄

joragua commented 3 weeks ago

Here, an update about quota in drawer:

Exceeded Quota Nearing Quota
Captura de pantalla 2024-10-09 a las 18 09 04 Captura de pantalla 2024-10-10 a las 8 19 42
Critical Quota Normal limited quota 
Captura de pantalla 2024-10-10 a las 9 44 17 Captura de pantalla 2024-10-09 a las 18 15 30

(Updated)

jesmrec commented 3 weeks ago

cool! just an small clarification, in the nearing message: i think Close to the quota limit sounds better

joragua commented 3 weeks ago

Hi @tbsbdr! 😄 We have some questions related with this issue. Do you agree with the string below numerical quota: The quota is exceeded, Close to the quota limit, Very close to the quota limit? How can we highlight all these strings to get the user's attention? We consider not to use colors because we could have problems with the branding.

joragua commented 3 weeks ago

This is how the manage accounts dialog looks with the quota:

Option 1 Option 2
Captura de pantalla 2024-10-11 a las 12 49 45 Captura de pantalla 2024-10-11 a las 12 59 49
Option 3
Captura de pantalla 2024-10-14 a las 10 23 25

Some comments about the options:

Option 1: You can see the quota in the progress bar and also in the text below it. But I you have some accounts at the same time, the dialog could be very big.

Option 2: The first option without the progress bar.

Option 3: One line with progress bar (If you have limit in the account) and used/total quota.

(It will be updated with more ideas)

jesmrec commented 3 weeks ago

option 3 merges 1 and 2. That's my favorite

tbsbdr commented 2 weeks ago

@joragua I observed that people don't know the word "quota", because of that I'd start to rename it to storage if you agree.

My proposal is:

  1. The quota is exceeded --> Storage full
  2. Close to the quota limit --> Storage nearly full
  3. Very close to the quota limit --> Storage very nearly full

Would that be an improvement?

get the user's attention

Hm.. I'd expect a color as a visual hint. If somehow possible and if not "too expensive", let's use a color. Note on branding: The comprehensive branding as we still provide it should be cut back in the future. With this in mind, I'd encourage to cut ties with the past where possible which can mean to not pay much attention to branding. just my 2 cents.

screenshot_003195

joragua commented 1 week ago

Tasks that are done ✅

Exceeded Quota Nearing Quota
Exceeded quota Nearing quota
Critical Quota Normal limited quota 
Critical quota Normal quota

Steps that are shown in the video 📹 : 1) Upload a file in the personal space (An automatic refresh will be done after this operation) 2) Copy the file in the personal space 3) Move the copy to a folder which contains the same file and replace it 4) Remove the original file from the personal space

https://github.com/user-attachments/assets/78be6ea9-c3a1-4873-a4e8-b9c6d174c248

Quota in manage accounts dialog