Closed Aitorbp closed 1 day ago
Everything related to the toolbar will be done in this issue: https://github.com/owncloud/android/issues/4365.
The list_item_lastmod_and_filesize_text
color has been changed to meet minimum contrast requirements. Apart from the places that it says in the issue, it has also been changed in:
In addition, the share_warning_text
color has been modified to meet with minimum contrast requirements. This text color is visible in the warning of public links and the text color has also been changed in:
You do not have permission to add content here!
textYou do not have permission to add content here!
textFYI @jesmrec @JuancaG05
The list_item_lastmod_and_filesize_text
color have been changed for this hex value #707575
to meet with the requirements:
Also we have created a new color share_warning_text
(#525757
) for public link warning description to meet the requirements:
Contrast checked used: https://webaim.org/resources/contrastchecker/
QA checks:
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #525757
vs #E0E0E0
➡️ 5.56 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #525757
vs #E0E0E0
➡️ 5.56 > 4.50 ✅
Contrast: #525757
vs #E0E0E0
➡️ 5.56 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
Contrast: #707575
vs #FFFFFF
➡️ 4.68 > 4.50 ✅
tested all views in portrait/landscape orientation.
Also, i took a look to the high contrast mode, which look is much better than before. Moving forward an accessible app step by step 💯
This is approved from my side.
Related Issues
App:
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA
https://github.com/owncloud/android/pull/4429#issuecomment-2205785319