owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.76k stars 3.09k forks source link

[a11y] 11.1.4.3 Contrast (minimum) #4429

Closed Aitorbp closed 1 day ago

Aitorbp commented 1 week ago

Related Issues

App:


QA

https://github.com/owncloud/android/pull/4429#issuecomment-2205785319

Aitorbp commented 3 days ago

Everything related to the toolbar will be done in this issue: https://github.com/owncloud/android/issues/4365.

Aitorbp commented 2 days ago

The list_item_lastmod_and_filesize_text color has been changed to meet minimum contrast requirements. Apart from the places that it says in the issue, it has also been changed in:

In addition, the share_warning_text color has been modified to meet with minimum contrast requirements. This text color is visible in the warning of public links and the text color has also been changed in:

FYI @jesmrec @JuancaG05

Aitorbp commented 2 days ago

The list_item_lastmod_and_filesize_text color have been changed for this hex value #707575to meet with the requirements:

list_item_lastmod_and_filesize_text

Also we have created a new color share_warning_text (#525757) for public link warning description to meet the requirements:

share_warning_text

Contrast checked used: https://webaim.org/resources/contrastchecker/

jesmrec commented 1 day ago

QA checks:

date and size in list of files

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

drawer footer (quota)

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

land-drawer footer (quota)

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

list footer (#files & #folders)

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

shared file size

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

warning public link

Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅

expiration date in public link

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

folder picker - target folder with no writing permissions

Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅

folder picker - share from 3rd party app to folder with no writing permissions

Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅

log size

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

upload list: status, size, date, account, space and target folder

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

bottom sheet: date and size

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

tested all views in portrait/landscape orientation.

Also, i took a look to the high contrast mode, which look is much better than before. Moving forward an accessible app step by step 💯

This is approved from my side.