[a11y] 11.1.4.11 Non-text contrast

[Aitorbp]

Related Issues

App:

• [x] Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• [x] Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

[Aitorbp]

Changes to SearchView have been made on the following screens:

• Search file main list
• Search space in Space view
• Search space in Select folder
• Picture upload path -> Choose destination folder
• Video upload path -> Choose destination folder
• Receive external files --> choose destination folder

No changes will be made to the Users and group SearchView in the Share view.

Now, the searchbar includes a new resource with rounded edges, using the same background color (brandable) as the containing toolbar: rounded_search_view.xml

The new color #B4BAC0 of the hint text meets the contrast requirements of the issue:

The search cross will be in white color to meet the contrast requirements:

[Aitorbp]

Research: First of all, we need to know that there are two toolbars currently working in the application: RootToolbar and StandardToolbar.

The RootToolbar is displayed in the following views:

• Main list of files root view
• Shares view
• Spaces root view
• Uploads view
• Available offline view

The StandardToolbar appears in the following views:

• Main list of files (non-root) view
• Spaces (non-root) view
• Set target path for auto-uploads
• Move and copy operations
• Sharing files with ownCloud from external apps (Share with)
• File previews
• Settings
• And more...

In this PR we are trying to unify the common appearance (colors, size...) of both toolbars in a single place. We are moving the general behaviour of the toolbar from the child classes to the ToolbarActivity, avoiding repeated code. Regarding the StandardToolbar, when we don't want the main_menu (which includes Search, Select all and Share buttons) to be displayed, we override the onCreateOptionsMenu method to not showing it, which is the default behaviour provided in ToolbarActivity.

This way, the following classes don't need to display the main_menu so we override this method to return false (won't be displayed):

• UploadListActivity ( Uploads view)
• ShareActivity (Shares view)
• PreviewImageActivity ( Image preview)
• PreviewVideoActivity (Video preview)

We need to do this now because these classes extend from ToolbarActivity and main_menu is attached to it.

On the other hand, we have fixed a bug. Now, when we are in the spaces view, the text hint of the SearchView is Search spaces.