owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.85k stars 3.06k forks source link

[FEATURE REQUEST] Quota improvements from GraphAPI #4496

Closed joragua closed 3 days ago

joragua commented 1 month ago

Related Issues

App:


QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.5/Quota.md

Reports:

joragua commented 2 weeks ago

Here, the tables that I made while I was debugging with all the values (oCIS and oC10):

oCIS

Case Used Available Total State Limit
Unlimited quota 302,7 MB -3 0 MB NORMAL -
Limited quota (under 75%) 302,7 MB 651 MB 953,7 MB  NORMAL 1GB
Limited quota (between 75% and 90%) 302,7 MB 59,7 MB 362,7 MB NEARING 380 MB
Limited quota (between 90% and 100%) 302,7 MB 31,1 MB 333,8 MB CRITICAL 350 MB
Limited quota (over 100%) 302,7 MB 0 MB 238,4 MB EXCEEDED 250 MB

oC10

Case Used Available Total State Limit
Unlimited quota 8,1 MB -3 0 MB - -
Limited quota (under 100%) 8,1 MB 0,1 MB 8,2 MB  - 8,2 MB
Limited quota (over 100%) 8,1 MB 0 MB 8,1 MB  - 7 MB
jesmrec commented 1 week ago

(1) (improvement) [DONE]

  1. Add many accounts (4 - 5)
  2. Open the manage accounts view
  3. Set the device in landscape

Current:

The view lacks of a scroll bar like the one in the file list.

Expected:

If the user has to scroll down to see more info, a scrollbar will give such information.

NOTE: Nothing to do with quota, but the quota existance makes the view taller and scroll is required with less accounts. Not a blocker and could be addressed in separated issue.

Xiaomi Redmi 13 Android 14 1e43f43a4

jesmrec commented 1 week ago

(2) [FIXED]

  1. Set the quota in 1GB (other value is also OK)
  2. Add files and folders, so that the % of occupation is 99% (my test was made jumping from a 98%, check the video below)

Current:

The message Storage nearly full is missing and bar is blue

Expected:

The message Storage nearly full is there and bar is red

https://github.com/user-attachments/assets/558d5ac9-ee69-4f95-9a7d-b29d51e1f0c3

Xiaomi Redmi 13 Android 14 1e43f43a4

jesmrec commented 1 week ago

(3) [FIXED]

Check the following quota values (same account)

Screenshot 2024-11-14 at 13 23 17

Screenshot 2024-11-14 at 13 22 58

I think that rounded values should be only applied to the quota limit and not to the used space. In that example, showing 1GB and 1.4GB makes a difference of 25% in the used storage, leading to confusion. However, showing 1.9 GB or 2GB is OK and a reasonable difference that can be rounded.

Xiaomi Redmi 13 Android 14 1e43f43a4

joragua commented 1 week ago

(2) and (3) should be fixed @jesmrec

jesmrec commented 1 week ago

@joragua regarding (3), if the value is integer (i mean, no decimal part), in manage accounts:

Current: 500.0 of 900 Expected: 500 of 900

i'd avoid to show decimals in that case

joragua commented 1 week ago

Check it now!

joragua commented 1 week ago

(1) is done with the last commit. Also, I've added a text label for quota state in landscape drawer.

jesmrec commented 4 days ago

just a question: the quota update after a sync operation is not done in oC10, is that right?

joragua commented 4 days ago

That's right. It's only supported in oCIS

jesmrec commented 3 days ago

Approved 👍