[FEATURE REQUEST] Add text labels to bottom nav bar

owncloud / android

:phone: The ownCloud Android App

GNU General Public License v2.0

3.85k stars 3.06k forks source link

[FEATURE REQUEST] Add text labels to bottom nav bar #4498

Closed Yogeshjindal closed 1 month ago

Yogeshjindal commented 1 month ago

Added text labels to the bottom nav bar Used default activeStateIndicator which will show which label is selected

Now, all the items in nav bar shows the labels and upon selection the activeIndicator is enabled which shows that which item is selected. Fix#4484

JuancaG05 commented 1 month ago

Hi @Yogeshjindal! Commits here keep not following conventional commits. They should be named like this: feat: add text labels in bottom bar chore: added calens file Also, as I reported in the previous PR, don't mention the active indicator in release notes or Calens file, you didn't actually modify it. This branch needs a rebase against master, otherwise we won't be able to merge it. Other than that, everything is good! 👍

JuancaG05 commented 1 month ago

This time I'll do the QA myself

Checks: 1. oCIS:

[x] Bottom bar looking (both orientations)
[x] Navigating between sections changes the active indicator
[x] Changing the device orientation keeps the bottom bar in the same status

2. oC10:

[x] Bottom bar looking (both orientations)
[x] Navigating between sections changes the active indicator
[x] Changing the device orientation keeps the bottom bar in the same status

JuancaG05 commented 1 month ago

Approved by QA! 🚀

tbsbdr commented 1 month ago

🎻cant wait to see it