[FEATURE REQUEST] Enforce OIDC auth flow - Githubissues

owncloud / android

:phone: The ownCloud Android App

GNU General Public License v2.0

3.85k stars 3.06k forks source link

[FEATURE REQUEST] Enforce OIDC auth flow #4516

Closed JuancaG05 closed 1 day ago

JuancaG05 commented 2 days ago

Related Issues

App: https://github.com/owncloud/android/issues/4500

[x] Add changelog files for the fixed issues in folder changelog/unreleased. More info here
[x] Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

jesmrec commented 1 day ago

QA checks:

enforce_oidc is false

[x] Regular oCIS server -> correct authentication & authorization
[X] Server with only OIDC -> error (shows basic auth credential fields)
[x] Basic auth -> correct authentication & authorization
[x] OAuth2 -> correct authentication & authorization

enforce_oidc is true

[X] Regular oCIS server -> correct authentication & authorization (uses OIDC)
[x] Server with only OIDC -> correct authentication & authorization
[X] Basic auth -> moved to browser
[X] OAuth2 -> correct authentication & authorization

new path field

[x] oauth2_redirect_uri_path is empty
[x] oauth2_redirect_uri_path is not empty

jesmrec commented 1 day ago

Great job!! problem solved with a clean solution 💯

Ready to go