owncloud / announcementcenter

:loudspeaker: Announcement Center for ownCloud
GNU Affero General Public License v3.0
13 stars 7 forks source link

[Tests-Only] Fix unit tests related to core issue 37358 and core PR 37103 #150

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

Part of issue https://github.com/owncloud/core/issues/37358

The signature of core lib/private/User/Manager.php get() changed to have a new 2nd parameter. See core PR https://github.com/owncloud/core/pull/37103

Adjust unit tests so that the mocking of userManager matches the way that phpunit sees the calls. Even though the new parameter is optional (has a default value), phpunit sees the call happening with the parameter having been set to its default value false

codecov[bot] commented 4 years ago

Codecov Report

Merging #150 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #150   +/-   ##
=========================================
  Coverage     98.83%   98.83%           
  Complexity       60       60           
=========================================
  Files             8        8           
  Lines           258      258           
=========================================
  Hits            255      255           
  Misses            3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65e52f4...028b475. Read the comment docs.