owncloud / brute_force_protection

Brute-force protection app for ownCloud
GNU General Public License v2.0
6 stars 5 forks source link

[Tests-Only] fix failing unit tests #119

Closed kiranparajuli589 closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #119 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage     70.00%   70.00%           
- Complexity       38       39    +1     
=========================================
  Files            11       11           
  Lines           170      170           
=========================================
  Hits            119      119           
  Misses           51       51           
Impacted Files Coverage Δ Complexity Δ
lib/Db/FailedLoginAttemptMapper.php 100.00% <100.00%> (ø) 6.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a391afe...8bc054c. Read the comment docs.

jvillafanez commented 4 years ago

Code-wise, changes look fine. We might need to include a PHPDoc to clarify the behaviour of the function. We probably should squash the commits, but other than that :+1:

phil-davis commented 4 years ago

I cherry-picked this code onto PR #117 and did some squashing. Let's see what happens to CI there. That is the PR that has all the other CI-related changes for PHP 7.4

phil-davis commented 4 years ago

worked - #117 has been merged