Closed kiranparajuli589 closed 4 years ago
Code-wise, changes look fine. We might need to include a PHPDoc to clarify the behaviour of the function. We probably should squash the commits, but other than that :+1:
I cherry-picked this code onto PR #117 and did some squashing. Let's see what happens to CI there. That is the PR that has all the other CI-related changes for PHP 7.4
worked - #117 has been merged
Codecov Report
100.00% <100.00%> (ø)
6.00 <0.00> (+1.00)
Continue to review full report at Codecov.