brute_force_protection 1.1.0

phil-davis commented 4 years ago

needs release at least because of issue #57 PR #90 (which also depends on core 10.5.0) And minor fix to docs link from PR #130

QA Issues found

[x] #134
[x] incomplete translations

phil-davis commented 4 years ago

Ref: discussion in issue #85

karakayasemi commented 4 years ago

documentation path fix https://github.com/owncloud/brute_force_protection/pull/130

HanaGemela commented 4 years ago

Product approval

[x] Ping pmaier to check info.xml description and screenshot
[x] Get approval on translations from pmaier

QA

[x] Generate Changelog
[x] Create QA Milestone and set the description to $version
[x] Move items from development to qa
[x] Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
[x] Create release branch with the format "release-$version"
[x] Create "Brute Force Protection 1.1.0" Test plan @davitol https://github.com/owncloud/brute_force_protection/issues/132

Documentation

[x] Changes in the docs needed? If so create issue in owncloud/docs.

Marketing

[x] Ping @owncloud/marketing

Build

All actions to be done on the release branch from here:

[x] Bump version in info.xml (no version suffix)
[x] Check php version dependency in info.xml
[x] Check minimum ownCloud version dependency in info.xml
[x] Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

[x] Create github tag for v${version}RC1 on release branch
[x] Build and sign RC tarball from github tag v${version}RC1 (see handbook for how to build)
[x] Upload as Github release using changelog entries
[x] Test and document in testplan => Final "Go" from QA (set 'QA-ready' label) => @davitol https://github.com/owncloud/brute_force_protection/issues/132

Final

[x] Check that no documentation issues are pending
[x] Rename last RC tarball to final
[x] Create github tag for final v${version} on release branch
[x] Upload as Github release using changelog entries

Publishing

[x] Upload tarball to marketplace (see handbook for details)
~~[ ] Publish tarball for customers (see handbook for details) - https://customer.owncloud.com and https://portal.owncloud.com~~
[x] Send mail to release-coordination with link to this ticket and to the changelog
[x] Copy email to rocket chat #updates channel

Post-release

[x] Rename QA milestone to $version
[x] Add a new 'Unreleased' section in CHANGELOG.md
[x] Create PR to merge changes back to the master branch with description "Closes #XYZ" with the release ticket number
[x] Close the milestone
[x] Ensure release template is up to date

HanaGemela commented 4 years ago

Tag has been created https://github.com/owncloud/brute_force_protection/releases/tag/v1.1.0RC1 but signing the tar doesn't work

karakayasemi commented 4 years ago

@HanaGemela This app initially developed by me as a community app. I can create a signed tarball for the QA team or hand over the key if you prefer.

HanaGemela commented 4 years ago

@davitol RC1 for testing https://github.com/owncloud/brute_force_protection/releases/tag/v1.1.0RC1

davitol commented 4 years ago

@davitol RC1 for testing https://github.com/owncloud/brute_force_protection/releases/tag/v1.1.0RC1

There is no Changelog file included in the tarball

phil-davis commented 4 years ago

PR #131 will get the changelog into the tarball.

HanaGemela commented 4 years ago

@karakayasemi could you please create a new signed RC2 tarball?

karakayasemi commented 4 years ago

RC2 release has been created in here: https://github.com/owncloud/brute_force_protection/releases/tag/v1.1.0RC2

davitol commented 4 years ago

* Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...

There are missing strings for Deutsch (Persönlich), Förmlich LGTM @pmaier1

Also arabics is missed:

pmaier1 commented 4 years ago

There are missing strings for Deutsch (Persönlich), Förmlich LGTM @pmaier1

Also arabics is missed:

Transifex shows 100% for German and Arabic. Issue with sync job, I guess.

davitol commented 4 years ago

Reopened (item from Changelog): https://github.com/owncloud/brute_force_protection/issues/31#issuecomment-688179553

jnweiger commented 4 years ago

Last source update to Transifex was June 13, 2020 Is that correct?

pmaier1 commented 4 years ago

Last source update: Aug 7th 2020, 03:47

davitol commented 4 years ago

String messages are not translated even in Förmlich German (Transifex contains the right string translated but it does not get translated using the app)

davitol commented 4 years ago

IMHO a possible blocker @karakayasemi @pmaier1 https://github.com/owncloud/brute_force_protection/issues/134

jnweiger commented 4 years ago

@karakayasemi I have tagged 1.1.0RC3 -- can you please build the tarball for our QA? thanks!

karakayasemi commented 4 years ago

I created a new tarball and published with 1.1.0RC3. Thank you for your help.

davitol commented 4 years ago

I created a new tarball and published with 1.1.0RC3. Thank you for your help.

Tested with Tarball located in https://github.com/owncloud/brute_force_protection/releases/download/v1.1.0RC3/brute_force_protection.tar.gz and LGTM

@jnweiger Please :shipit:

jnweiger commented 4 years ago

@karakayasemi 1.1.0 passed QA, you can now proceed with the upload to https://marketplace.owncloud.com/apps/brute_force_protection

karakayasemi commented 4 years ago

https://marketplace.owncloud.com/apps/brute_force_protection v1.1.0 has been released. 🎉

karakayasemi commented 4 years ago

@jnweiger is there anything left to be done for closing this ticket? I saw some steps about mailing and re-opened the issue.

jnweiger commented 4 years ago

Mailings done, release checklist complete. final close.

owncloud / brute_force_protection