owncloud / brute_force_protection

Brute-force protection app for ownCloud

GNU General Public License v2.0

6 stars 5 forks source link

[Tests-Only] remove @issue-112 tags from acceptance tests #139

Closed karakayasemi closed 3 years ago

karakayasemi commented 3 years ago

https://github.com/owncloud/core/pull/37948 should resolve #112 We can merge this one after the core pr.

karakayasemi commented 3 years ago

@phil-davis is there any way to run tests against specific branch of owncloud/core? I want to tests this PR against loginexception branch of core. But, I could not figure out in a first look.

phil-davis commented 3 years ago

@karakayasemi see PR #140 - owncloudci/core needs to be given git_reference We never built-in any obvius way to do that in the top config section of the starlark.

karakayasemi commented 3 years ago

@karakayasemi see PR #140 - owncloudci/core needs to be given git_reference We never built-in any obvius way to do that in the top config section of the starlark.

Yes, I saw the PR. Thank you for your help.

codecov[bot] commented 3 years ago

Codecov Report

Merging #139 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage     71.87%   71.87%           
  Complexity       53       53           
=========================================
  Files            13       13           
  Lines           256      256           
=========================================
  Hits            184      184           
  Misses           72       72

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66066fd...569d569. Read the comment docs.

karakayasemi commented 3 years ago

We can merge this after CI worked with new nightly tarball and we see green CI.

phil-davis commented 3 years ago

Rebased to force fresh CI to run. Can merge when green.

phil-davis commented 3 years ago

https://drone.owncloud.com/owncloud/brute_force_protection/1196/17/10 The scenarios are still getting 500 status. Oh - https://download.owncloud.org/community/daily/owncloud-daily-master-qa.tar.bz2 is still from 2020-10-16. The daily master QA tarball has not been built the last 5 days. I have asked for someone to look into it.

phil-davis commented 3 years ago

daily-master-qa tarball has been updated. I restarted drone. Let's see...

phil-davis commented 3 years ago

success - the issue is fixed :tada: