[full-ci] Updated drone starlark file

amrita-shrestha commented 2 years ago

Description

This is an update on drones.star file

using drone-cancel-previous-builds
using thegeeklab/drone-github-comment instead of jmccann/drone-github-comment for github comments
moving docker image references to constants
using caches images
Do not run PHP unit tests with Oracle by default

Related Issue

ownclouders commented 2 years ago

:boom: Acceptance tests pipeline apiBruteForceProtection-master-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/brute_force_protection/1817/15

phil-davis commented 2 years ago

There are more changes in the activity app. Please just copy the whole starlark code from what is in the activity app master branch.

phil-davis commented 2 years ago

I still see a lot of diffs:

diff --git a/.drone.star b/.drone.star
index 8eddbbc..5ea1822 100644
--- a/.drone.star
+++ b/.drone.star
@@ -1,5 +1,5 @@
 BANST_AWS_CLI = "banst/awscli"
-DRONE_CI_ALPINE = "drone/cli:alpine"
+DRONE_CLI = "drone/cli:alpine"
 MAILHOG_MAILHOG = "mailhog/mailhog"
 MINIO_MC = "minio/mc:RELEASE.2020-12-18T10-53-53Z"
 OC_CI_ALPINE = "owncloudci/alpine:latest"
@@ -7,6 +7,7 @@ OC_CI_BAZEL_BUILDIFIER = "owncloudci/bazel-buildifier"
 OC_CI_CEPH = "owncloudci/ceph:tag-build-master-jewel-ubuntu-16.04"
 OC_CI_CORE = "owncloudci/core"
 OC_CI_DRONE_CANCEL_PREVIOUS_BUILDS = "owncloudci/drone-cancel-previous-builds"
+OC_CI_DRONE_SKIP_PIPELINE = "owncloudci/drone-skip-pipeline"
 OC_CI_NODEJS = "owncloudci/nodejs:%s"
 OC_CI_ORACLE_XE = "owncloudci/oracle-xe:latest"
 OC_CI_PHP = "owncloudci/php:%s"
@@ -218,15 +219,16 @@ def codestyle(ctx):
                     "base": dir["base"],
                     "path": "server/apps/%s" % ctx.repo.name,
                 },
-                "steps": [
-                    {
-                        "name": "coding-standard",
-                        "image": OC_CI_PHP % phpVersion,
-                        "commands": [
-                            "make test-php-style",
-                        ],
-                    },
-                ],
+                "steps": skipIfUnchanged(ctx, "lint") +
+                         [
+                             {
+                                 "name": "coding-standard",
+                                 "image": OC_CI_PHP % phpVersion,
+                                 "commands": [
+                                     "make test-php-style",
+                                 ],
+                             },
+                         ],
                 "depends_on": [],
                 "trigger": {
                     "ref": [
@@ -261,15 +263,16 @@ def jscodestyle(ctx):
             "base": dir["base"],
             "path": "server/apps/%s" % ctx.repo.name,
         },
-        "steps": [
-            {
-                "name": "coding-standard-js",
-                "image": OC_CI_NODEJS % DEFAULT_NODEJS_VERSION,
-                "commands": [
-                    "make test-js-style",
-                ],
-            },
-        ],
+        "steps": skipIfUnchanged(ctx, "lint") +
+                 [
+                     {
+                         "name": "coding-standard-js",
+                         "image": OC_CI_NODEJS % DEFAULT_NODEJS_VERSION,
+                         "commands": [
+                             "make test-js-style",
+                         ],
+                     },
+                 ],
         "depends_on": [],
         "trigger": {
             "ref": [
@@ -358,7 +361,8 @@ def phpstan(ctx):
                     "base": dir["base"],
                     "path": "server/apps/%s" % ctx.repo.name,
                 },
-                "steps": installCore(ctx, "daily-master-qa", "sqlite", False) +
+                "steps": skipIfUnchanged(ctx, "lint") +
+                         installCore(ctx, "daily-master-qa", "sqlite", False) +
                          installAppPhp(ctx, phpVersion) +
                          installExtraApps(phpVersion, params["extraApps"]) +
                          setupServerAndApp(ctx, phpVersion, params["logLevel"], False, params["enableApp"]) +
@@ -431,7 +435,8 @@ def phan(ctx):
                     "base": dir["base"],
                     "path": "server/apps/%s" % ctx.repo.name,
                 },
-                "steps": installCore(ctx, "daily-master-qa", "sqlite", False) +
+                "steps": skipIfUnchanged(ctx, "lint") +
+                         installCore(ctx, "daily-master-qa", "sqlite", False) +
                          [
                              {
                                  "name": "phan",

and more...

We really need to just copy-paste the whole code.