[tests-only][full-ci]Use directory references from global dir variable in drone.star file

amrita-shrestha commented 2 years ago

Description

it is better to use directory references from the dir var, rather than using the hard-coded values in every use case.

Related Issue

https://github.com/owncloud/QA/issues/734#issue-1173320353

Motivation and Context

How Has This Been Tested?

CI

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Database schema changes (next release will require increase of minor version instead of patch)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:
[ ] Changelog item, see TEMPLATE

phil-davis commented 2 years ago

The drone starlark code for the oC10 apps is the same. We want to keep it the same. So please also do a PR to the activity app with the same changes to the "dir" array and to the starlark code, to demonstrate that it works there. Then we can merge both PRs, and after that, apply the changes to all the other oC10 apps CI.