search

owncloud / calendar

Calendar app for ownCloud
GNU Affero General Public License v3.0
121 stars 43 forks source link

Sharing button hidden when using an adblocker #235

Open tomneedham opened 8 years ago

tomneedham commented 8 years ago

Steps to reproduce

  1. Hover over a calendar

    Expected behaviour

Should see share icon screen shot 2016-02-25 at 15 01 05

Actual behaviour

Isnt shown screen shot 2016-02-25 at 15 00 53

Same as contacts https://github.com/owncloud/contactsrework/issues/54

georgehrke commented 8 years ago

@tomneedham Do you use some kind of ad-blocker?

tomneedham commented 8 years ago

Exactly what I'm checking ;)

tomneedham commented 8 years ago

Yup, blocked by https://adblockplus.org. Just trying to see what rule is triggering it.

jancborchardt commented 8 years ago

Ah crap, we had something like this in the past for Files as well. We should contact Adblock Plus and provide them with a rule to counter this. @tomneedham once you find out what triggers this can you take care?

tomneedham commented 8 years ago

Yeah will do. I thought it would be the class icon-share but apparently not.. digging.

tomneedham commented 8 years ago

Currently I see this issue with Safari 9.0.3 and Adblock Plus

jancborchardt commented 8 years ago

It’s definitely something with the word »share«. Be it in the image or in the CSS.

tomneedham commented 8 years ago

https://adblockplus.org/forum/viewtopic.php?f=18&t=44184 tracked here as well whilst I try and debug this.

tomneedham commented 8 years ago

It seems 'Fanboy's Social Blocking List' is the culprit at least for me, even though ABP says zero ads are blocked on the page.

tomneedham commented 8 years ago

From the forum discussion:

Reproduced in Firefox and Chrome. Blockable items shows that the offending rule is ##.icon-share in the Fanboy's Social Blocking List.

Reported to the EasyList forum, pending approval from a mod. @jancborchardt Can you confirm which lists you had installed that caused this issue? I've requested that we get icon-share allowed so that all ownCLoud apps can utilise the core icons.

georgehrke commented 8 years ago

@tomneedham What's the status on this one?

tomneedham commented 8 years ago

It's due to the 'icon-class'. Not sure why this isn't picked up in core, as the rules are basically checking for anything with .icon-class.

georgehrke commented 8 years ago

ok, let's move this to 1.1 and tell people to disable their adblocker for ownCloud in the meantime

georgehrke commented 8 years ago

@tomneedham Any update?