Open michaelstingl opened 2 years ago
Could not reproduce this with the server you mentioned, they ship valid URLs apparently. However, a local deployment of the ocis_keycloak
example allows me to reproduce the problem. Working on a solution.
Did you try it with mitmproxy? Mitmproxy usually adds another layer of self signed certs.
Yes, in my case, both hosts had perfectly fine certificates, but using mitmproxy
broke them (of course), and I didn't install the mitmproxy
hacky-hacky certificates on my machine. (I forgot mitmproxy
in the "Steps to reproduc", sorry)
Ah, I see. Yeah, makes sense. I'll use my current setup for testing for now.
For the record, it looks like the ocis_keycloak
example is perfectly supported. The error I see is coming from the oCIS server, it returns a 500 response when fetching the user information. The custom TLS certificate handling works as expected. I'd ignore this one for now, seems like a bug within a development release of oCIS.
This issue can be reproduced with mitmproxy 8.x only, 6.x behaves differently. Apparently, mitmproxy 8 uses host-specific certificates, whereas version 6 uses one certificate for all hosts. The latter works well with the current system. Supporting a second custom certificate per account however is anything but trivial currently, since we have to mix libsync
and gui
code (FetchUserInfoJobFactory
needs to display such a dialog). I started working on a "chain-of-responsibility"-based fix, but overall, I'm not sure it's worth the effort...
The error I see is coming from the oCIS server, it returns a 500 response when fetching the user information.
I'll open a separate issue…
Supporting a second custom certificate per account however is anything but trivial currently, since we have to mix
libsync
andgui
code (FetchUserInfoJobFactory
needs to display such a dialog).
No urgency for now.
The error I see is coming from the oCIS server, it returns a 500 response when fetching the user information.
I'll open a separate issue…
Here we go… https://github.com/owncloud/ocis/issues/4616
Pre-submission Checks
Describe the bug
While debugging some stuff using
mitmproxy
, I encountered an issue where the host from the ownCloud instance is different from the token endpoint. (Keycloak IdP in this case)Expected behavior
ownCloud desktop sync client should raise a new TLS error and accept window for the new host.
Steps to reproduce the issue
einstein:relativity
Screenshots
Logs
Client version number
Desktop environment (Linux only)
No response
Client package version and origin (Linux only)
No response
Installation path (Windows only)
No response
Server information
https://owncloud.dev/ocis/deployment/continuous_deployment/#ocis-with-keycloak
Additional context
@fmoc please have a look