owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.4k stars 663 forks source link

[full-ci] Fix crash when removing an oc10 sync connection #11875

Closed erikjv closed 1 month ago

erikjv commented 2 months ago

Fixes: #11814

erikjv commented 2 months ago

Do not merge yet: rebase on top of #11882 (when that is merged) before merging this PR.

erikjv commented 2 months ago

Tested the branch and the crash is fixed. The fail in the CI is different one: https://drone.owncloud.com/owncloud/client/19349/5/12

@erikjv you can remove the @skip tag from this scenario and add [full-ci] in the PR title to run the tests against oc10

https://github.com/owncloud/client/blob/f986f6e644a21637fc4c08cda30827fdca0bbef0/test/gui/tst_syncing/test.feature#L492-L493

Done

saw-jan commented 1 month ago

Test is passing :+1:

saw-jan commented 1 month ago

Sorry, my mouse click slipped :sweat_smile: