owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.4k stars 662 forks source link

Default to the monochrome icon set where it makes sense #2342

Open strugee opened 10 years ago

strugee commented 10 years ago

For example, Mirall should default to monochrome icons on OS X, GNOME, MATE, and Unity, because monochrome icons fit in better than color icons when using these platforms.

However, e.g. KDE(?) and Windows should retain the current behavior, because colored icons are the norm on those platforms.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5415958-default-to-the-monochrome-icon-set-where-it-makes-sense?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github).
Goutte commented 8 years ago

An update : In recent versions of KDE (packaged with kubuntu 15.10 and 16.04), black monochrome icons are used. Owncloud still uses white monochrome icons right now, that are hardly visible.

owncloud_white_monochrome_icon_failure

Love the software :cupid:

strugee commented 8 years ago

@Goutte that's a totally separate problem. Please file a new issue.

@LukasReschke seems like this is done; can this be closed?

LukasReschke commented 8 years ago

My commit has been reverted because it collided with the proprietary ownBrander code and platform. So at least on OS X, no this is not done.

danimo commented 8 years ago

@LukasReschke This is not related to ownBrander as such, it just wasnt the right place to make the change.

The issue is a different one. Essentially we have to balance between two issues:

Usually, I would say "By all means, make it native", BUT there is the problem that ownCloud would need better ways to detect the color of the operating system icons (which is what this very issue is about). On Linux, this is covered by shipping the icon themes that the platform expects. But those are simply too many to ship. So until we find a good solution there, at least on Linux I would not default do monochrome.

LukasReschke commented 8 years ago

If we make the icon adjust to the platform by default, people who know it from another platform suffer from discoverability issues. Same reason Dropbox defaults to colored icons on Mac.

That is not the case. Dropbox uses monochrome icons by default on OS X since a longer time. (at least 1.5 years)

So the only reason to revert that change on OS X, was in my knowledge fixing some ownBrander stuff.

LukasReschke commented 8 years ago

Even further, it's not even possible anymore to change that setting in Dropbox. They simply take the assumption that you don't want colorful icons at all (which is ok, as there aren't really any applications where you can change that): 2016-09-08_13-31-26

LukasReschke commented 8 years ago

Anyhow, I guess asking to just drop the colorful scheme for OS X here won't get me any friends ;-) – If there is some interest though, let me know and I'll happily do another Pull Request ;-)

That one would remove the button on OS X and default to the monochrome icon set. Or we can just default to the monochrome… The colorful ones just really look strange on OS X :-/

Goutte commented 8 years ago

@strugee Sorry, I posted here because you said that skeuomorphed icons were the norm on KDE, which it is not anymore. It's all flat, flat, flat !

Also, after rebooting, owncloud now correctly uses black icons in the systray !? I'm a happy chappie !

strugee commented 8 years ago

@Goutte it's no problem; I'm just helping the project to organize :)

tsparber commented 8 years ago

Defaulting to mono on macOS is being worked (again) on in #5229.