search

owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.4k stars 663 forks source link

Windows 8 high contrast is unreadable #2654

Closed stonewareslord closed 9 years ago

stonewareslord commented 9 years ago

Actual behavior

When using the high contrast themes in Windows, the ownCloud sync client is unreadable: high contrast And when switching back to Aero Lite, the Storage Usage bar doesn't change: aero lite

Steps to reproduce

  1. Switch to high contrast mode

    Client configuration

Operating system: Windows 8 OS language: English Installation path of client: Default

luciamaestro commented 9 years ago

I can't reproduce it, when I use high contrast mode I see this: contrast-mode-1 7 Can you test it in the latest build? http://download.owncloud.com/desktop/daily/ If it is still happening please reopen it. Thx

stonewareslord commented 9 years ago

I will test it in a few hours, but did you try selecting the folder?

stonewareslord commented 9 years ago

Ok. I created another folder. The wallpaper folder looks like yours and isn't selected. The one below it is selected (I left clicked it). capture I'm using 1.8.0-nightly 20150108 (build 4536)

jturcotte commented 9 years ago

This seems to have magically been fixed by the multiaccount UI update.

phil-davis commented 9 years ago

I tried theme "High Contrast 1" on Windows 10. I can read everything and see the storage usage bar - good. The only missing component I noticed is that the file download progress bar is all black. There is no visual of the download progress (the text of what is downloading is seen and works). I guess this is a "black-on-black" rendering somewhere caused by whatever is mapping the normal green-on-white to black-on-black.

jturcotte commented 9 years ago

Oh man, you're thorough! :) I'm trying to find out why and I can't see anything wrong. We don't give any specific color to Qt for this widget and it also works well with "-style windowsxp" and I can't see anything that we could set better in QStyleOptionProgressBarV2. Could this be a bug in the Qt windowsvista style?

If I use the High Contrast White theme I can see that the Vista theme renders the progress as grey, while the XP one renders it properly with dark purple.

But, if I run the the progressdialog example, both style work well, so we must be doing something different than QProgressBar.

@ogoffart Can you think of anything?

jturcotte commented 9 years ago

Ah, if I remove the line "pBarOpt.palette = palette;" it works well.

phil-davis commented 9 years ago

Let me know if/when there is anything in a build and I can easily test.

jturcotte commented 9 years ago

Yes not yet, I'll push the fix once we released beta1 just to possibly not get in the way of higher priority stuff.

guruz commented 9 years ago

ownCloud-2.0.0.5381-nightly20150810-setup.exe should have this.

phil-davis commented 9 years ago

I tried 2.0.0.5381 on Windows 10 with High Contrast Theme 1. Yes the progress bar is displayed and changes during upload/download - good. On the top section of the UI the words cannot be seen - names of the accounts, "Activity", "General", "Network". Personally I have no need for high contrast theme, but maybe somebody cares? highcontrast

phil-davis commented 9 years ago

Just documenting here that there is no change in behaviour with build 2.0.0.5384 Need to wait for the next build to see the effect of the changes made to try and also address #3582

guruz commented 9 years ago

New nightly for Windows http://download.owncloud.com/desktop/daily/ownCloud-2.0.0.5388-nightly20150811-setup.exe

phil-davis commented 9 years ago

Windows ownClient 2.0.0.5388 still has the same behaviour. The currently highlighted icon is now blue, OK.The text of the non-highlighted icons is not visible. I guess it is white-on-white - like trying to find a polar bear in a snowstorm. highcontrast1 How much time is this worth?

danimo commented 9 years ago

@phil-davis It works now, but it doesn't change when the color theme is getting changed (i.e. you need to close and reopen). I am still not too happy because the icons are dark, and therefore almost not visible in high-contrast mode.

phil-davis commented 9 years ago

You are right - after "Quit ownCloud" and start it again then I can see the text. But the icons for each are not visible (black-on-black). I guess these themes with nasty mixes of colours are a pain. I certainly switch straight back after a 30 second test. Edit add: Oh, the icons are there - they are dark-grey on black. highcontrast2 Just as an aside, when I switch the themes back and forth my Firefox stop working properly - it gives up being able to resolve DNS! I exit completely, saving my tabs, and restart and it is fine. So ownCloud is not the only app that does weird stuff when already running and the theme changes.

danimo commented 9 years ago

image

This is the best I can do for 2.0 (includes switching on the fly as the theme changes!). I think that's ok for now.

phil-davis commented 9 years ago

ownCloud client 2.0.0.5390 works well for me. I tried High Contrast 1, Black and White. And it all switched back and forth on-the-fly without me ever needing to do a full restart of the app.