search

owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.4k stars 665 forks source link

Minor Windows Installer Issue: Missing descriptions on the "Choose Components" screen #382

Closed fastfwd-zz closed 11 years ago

fastfwd-zz commented 11 years ago

On the "Choose Components" screen, the "Description" box says "Position your mouse over a component to see its description".

Expected behaviour

Positioning the mouse over each component shows a description of that component.

Actual behaviour

Only descriptions for "Start Menu Program Group", "Desktop Shortcut", and "Quick Launch Shortcut" appear. There are no descriptions for the base "ownCloud" component or for the "Autostart" component (or for the "Shortcuts" parent of the three shortcut components).

Steps to reproduce

  1. Run the installer.
  2. Click Next until the "Choose Components" screen appears.
  3. Hover the mouse pointer over the components.

    Client configuration

Client version: 1.2.1 Operating system: Win7-64 OS language: English Installation path of client: default

fastfwd-zz commented 11 years ago

Issue still exists in client version 1.2.3.

fastfwd-zz commented 11 years ago

Issue still exists in client version 1.2.4.

Is it best to post this information in a comment, or to edit the bug description?

danimo commented 11 years ago

@fastfwd It's always best to submit a patch. It's not nice but by no means critical :-)

Here's a small hint:

https://github.com/owncloud/mirall/blob/master/cmake/modules/NSIS.template.in#L459 https://github.com/owncloud/mirall/blob/master/cmake/modules/NSIS.template.in#L270 vs.

https://github.com/owncloud/mirall/blob/master/cmake/modules/NSIS.template.in#L474 ff.

(sections are named inconsistently)

If you don't feel like it, I can fix it as well but I thought it might be an incentive for you to give it a try since you have a fork of mirall in your github account already :-)

fastfwd-zz commented 11 years ago

Thank you, Daniel. You are right, of course.

In the USA, federal income tax forms must be mailed by 15 April, so I will be busy this weekend... But the fix seems pretty obvious, so maybe I will have time before Monday to learn enough about git, github, and building mirall for Windows.

danimo commented 11 years ago

@fastfwd bump?

fastfwd-zz commented 11 years ago

It is the third item on my to-do list (after debugging a little of my C and someone else's assembly)... Which means that I will reach it either this weekend or never.