owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.4k stars 668 forks source link

Delete to be deleted files before downloading new files #5077

Open TeddyM-DK opened 8 years ago

TeddyM-DK commented 8 years ago

Expected behaviour

Delete obselete files/folders on client PC before downloading new files to PC

Actual behaviour

Download before before deleting

Steps to reproduce

  1. make sure 2 client PC's are synced. PC1 must be maxed out (space). PC2 must have more space than PC1..
  2. pause sync on PC1
  3. delete some files on PC2 and add also new files (not the old ones deleted before) on PC2 so the space is near (not over) the limit of PC1.
  4. make sure the files are synced to the server.
  5. enable sync on PC1
  6. cry over you have to delete ALL data on PC1 and reinitialize folder sync from scratch.

Server configuration

Operating system: Linus Mint 17.3

Web server: Lighttpd (can't remember the version)

Database: MariaDB (MySQL derivate) 5.5.49

PHP version: 5.5.9 ownCloud version: 9.0.1 Storage backend: local

Client configuration

Client version: 2.2.2

Operating system: Win 10 OS language: US Installation path of client: default

Logs

Regarding logs, I do not have access to them from work. But if required I can find them (with help from you guys and girls)

I am not a coder, but to me it seems like downloading has higher priority than deleting.

If I am to decide (I know I am not) I would say: Data sent TO server has higher priority than data deleting processes sent from client. Data delting processes sent FROM server to client has higher priority than data sent to server from client.

So obselete data is removed first then replaced by new data. I find wrong data is worse than no data. I know I may be the onnly one sharing this view. ;)

/Teddy P.s Sorry for misspell and funny syntax, english is my second language...

guruz commented 8 years ago

Interesting issue FYI @ogoffart

Semi related https://github.com/owncloud/client/issues/2128 https://github.com/owncloud/client/issues/4498