[2.2.3] [Overlays] dolphin plugin fails with branding - Githubissues

owncloud / client

🖥️ Desktop Syncing Client for ownCloud

GNU General Public License v2.0

1.4k stars 663 forks source link

[2.2.3] [Overlays] dolphin plugin fails with branding #5165

Closed olifre closed 8 years ago

olifre commented 8 years ago

As can be seen in: https://github.com/owncloud/client/blob/master/shell_integration/dolphin/ownclouddolphinpluginhelper.cpp#L70 the socket is hardcoded to ownCloud/socket in the XDG-path which naturally will fail if the APPLICATION_SHORTNAME is set via OEM.cmake.

Expected behaviour

Overlay icons and integration works with dolphin.

Actual behaviour

If owncloud-client and branded client installed, overlay icons are duplicated on owncloud folder, branded directory has no overlays.

Client configuration

Client version: 2.2.3

Operating system: Gentoo Linux

olifre commented 8 years ago

I can confirm from my side that applying the patch on top of the 2.2.3 release using a branded client (cernbox) indeed fixes the issue. Thanks for this fast fixing!