search

owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.4k stars 662 forks source link

Refactoring: Move the ConfigFile class out of libsync #6213

Open ogoffart opened 6 years ago

ogoffart commented 6 years ago

ConfigFile is currently in the libsync folder. However, the sync engine should not read directly from the config file but should have all its parameter passed in the SyncOptions class.

Rationale: We don't want the tests, owncloudcmd, or other applications to share or mess with the same config file.

guruz commented 6 years ago

Only place missing:

src/libsync/creds/httpcredentials.cpp:    auto settings = ConfigFile::settingsWithGroup(Theme::instance()->appName());
ckamm commented 6 years ago

So it looks like we need to move the parts of HttpCredentials that interact with the keychain into gui and we're done. I don't think it's critical for 2.6, moving.

ogoffart commented 6 years ago

Right, we will refactor the credentials once we can get rid of shibboleth