owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.38k stars 668 forks source link

Support opentelemetry.io #7595

Open butonic opened 4 years ago

butonic commented 4 years ago

https://opentelemetry.io/ allow tracing requests from client to server.

michaelstingl commented 4 years ago

@TheOneRing effort estimation? Should this be part of the client or should this be better a Qt thingy?

michaelstingl commented 4 years ago

Ah, they have a C++ library: https://github.com/open-telemetry/opentelemetry-cpp

TheOneRing commented 4 years ago

There would also be https://api.kde.org/frameworks/kuserfeedback/html/index.html (not related to open-telemetry)

TheOneRing commented 4 years ago

Ah, they have a C++ library: https://github.com/open-telemetry/opentelemetry-cpp

Its just a bunch of empty folders at the moment.

butonic commented 4 years ago

opencensus has merged with opentracing into opentelemetry. maybe they will continue to use the opencensus stuff in https://github.com/census-instrumentation/opencensus-cpp in ocis / reva we currently use opencensus, but will switch once telemetry is becoming stable.

butonic commented 4 years ago

related: https://github.com/owncloud/client/issues/4606

tboerger commented 4 years ago

IMHO this doesn't really make sense for clients, this only makes sense for complex micro service architectures where it's hard to debug the flow of requests.

ogoffart commented 4 years ago

What exactly is the client supposed to log? I believe logging request would be better done on the server side.

michaelstingl commented 2 years ago

W3C specification that defines standard HTTP headers and a value format to propagate context information that enables distributed tracing scenarios: https://www.w3.org/TR/trace-context/#examples-of-http-traceparent-headers