search

owncloud / client

🖥️ Desktop Syncing Client for ownCloud
GNU General Public License v2.0
1.4k stars 662 forks source link

Make 403 Forbidden message user friendly #7758

Open HanaGemela opened 4 years ago

HanaGemela commented 4 years ago

Server: 10.4.0 RC3 Client: 2.6.1 (build 13096)

Steps to recreate: 1) Add 'blacklisted_files_regex' => [ '.*\.jpg' ], into config.php on the server 2) Create a new file 123.jpg in the client 3) Sync

Actual result: 403 Forbidden message Expected result: Nice user friendly message

Similar with secure view https://github.com/owncloud/client/issues/7604#issue-524404600 and file firewall https://github.com/owncloud/client/issues/7604#issuecomment-555414003

Also the error message is shown every single sync. Yes, the sync should fail as it is a blacklisted file but on the other hand the sync was also successful because it did not synced the files that were not supposed to be synced. It is a bit harsh to fail the sync, shouldn't the files be rather ignored?

mmattel commented 4 years ago

Please see my comment in https://github.com/owncloud/ios-app/issues/623#issuecomment-589751281