[QA] client never retries a locked file

jnweiger commented 3 years ago

Seen with server core 10.6.0, wopi-1.5.0RC2 and testpilotcloud client 2.7.7 daily20210303 (3434)

Edit a .docx file with MSOO Word via wopi
the file gets locked.
the client frequently syncs down any changes made in MSOO. OK
edit the file locally using e.g. lowriter- the edit can be saved. Okayish.
the client complains about '423 Locked'. Okayish
close the MSOO Word editor. the file gets unlocked.
wait for the client to retry. Wait 10 minutes. The 23 Locked' error persists

Screenshot from 2021-03-08 00-48-59

Expected behaviour: the next sync run should detect the lock is gone and attempt a sync. (potentially resulting in a conflict, of course) (Enhancement: Can we forward the locked state to lowriter, so that the user is warned earlier?)

Workaround: force sync. This immediately tries to sync, and indeed results in a conflict, when the file was also edited in MSOO Word, but syncs the changes cleanly to the server, when no edits were made in MSOO Word. Nice.

TheOneRing commented 3 years ago

The current client has no support for server side locks. As on normal issues the client should put the file on the retry list and retry it periodically. The timeout for that might grow to 24h. As usual please provide logs.

Improved handling of server side locks needs to be discussed. @micbar @michaelstingl @pmaier1

micbar commented 3 years ago

The topic is on the PM roadmap.

michaelstingl commented 3 years ago

Without improved handling of server side locks, client should perform regular retry-list-behavior with 4xx errors? (double the timespan before retry, max. up to 24h)

github-actions[bot] commented 3 years ago

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

2403905 commented 2 months ago

owncloud / client

[QA] client never retries a locked file #8477