search

owncloud / contacts

:busts_in_silhouette: Manage your CardDAV contacts from a feature-rich web-interface
75 stars 46 forks source link

javascript-tests pipeline is failing and needs further investigation #735

Closed SwikritiT closed 2 years ago

SwikritiT commented 2 years ago

Build: https://drone.owncloud.com/owncloud/contacts/1229/4/4

+ cd /var/www/owncloud/server/apps/contacts
+ make npm
npm run build

> contacts@1.5.4 prebuild /var/www/owncloud/server/apps/contacts
> npm install && npm update && node_modules/bower/bin/bower install && node_modules/bower/bin/bower update

npm WARN deprecated codecov@3.8.3: https://about.codecov.io/blog/codecov-uploader-deprecation-plan/
npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead:
npm WARN deprecated   npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.
npm WARN deprecated wreck@6.3.0: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated gulp-util@3.0.8: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated formatio@1.1.1: This package is unmaintained. Use @sinonjs/formatio instead
npm WARN deprecated samsam@1.1.2: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated hoek@2.16.3: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated boom@2.10.1: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated samsam@1.1.3: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated request@2.88.0: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

> wd@1.14.0 install /var/www/owncloud/server/apps/contacts/node_modules/wd
> node scripts/build-browser-scripts

> es5-ext@0.10.60 postinstall /var/www/owncloud/server/apps/contacts/node_modules/es5-ext
>  node -e "try{require('./_postinstall')}catch(e){}"

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/karma/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 889 packages from 1634 contributors and audited 891 packages in 27.622s

47 packages are looking for funding
  run `npm fund` for details

found 31 vulnerabilities (2 low, 12 moderate, 11 high, 6 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
bower ESUDO         Please do not run with sudo

Additional error details:
Since bower is a user command, there is no need to execute it with superuser permissions.
If you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs.

http://www.joyent.com/blog/installing-node-and-npm
https://gist.github.com/isaacs/579814

You can however run a command with sudo using "--allow-root" option
bower ui-select#0.14.9      not-cached https://github.com/angular-ui/ui-select.git#0.14.9
bower ui-select#0.14.9         resolve https://github.com/angular-ui/ui-select.git#0.14.9
bower angular-bootstrap#1.1.2       not-cached https://github.com/angular-ui/bootstrap-bower.git#1.1.2
bower angular-bootstrap#1.1.2          resolve https://github.com/angular-ui/bootstrap-bower.git#1.1.2
bower angular-sanitize#1.5.8        not-cached https://github.com/angular/bower-angular-sanitize.git#1.5.8
bower angular-sanitize#1.5.8           resolve https://github.com/angular/bower-angular-sanitize.git#1.5.8
bower angular-cache#4.6.0           not-cached https://github.com/jmdobry/angular-cache.git#4.6.0
bower angular-cache#4.6.0              resolve https://github.com/jmdobry/angular-cache.git#4.6.0
bower angular-route#1.5.8           not-cached https://github.com/angular/bower-angular-route.git#1.5.8
bower angular-route#1.5.8              resolve https://github.com/angular/bower-angular-route.git#1.5.8
bower ngclipboard#^1.1.1            not-cached https://github.com/sachinchoolur/ngclipboard.git#^1.1.1
bower ngclipboard#^1.1.1               resolve https://github.com/sachinchoolur/ngclipboard.git#^1.1.1
bower angular-mocks#1.5.8           not-cached https://github.com/angular/bower-angular-mocks.git#1.5.8
bower angular-mocks#1.5.8              resolve https://github.com/angular/bower-angular-mocks.git#1.5.8
bower angular#1.5.8                 not-cached https://github.com/angular/bower-angular.git#1.5.8
bower angular#1.5.8                    resolve https://github.com/angular/bower-angular.git#1.5.8
bower underscore#^1.8.3             not-cached https://github.com/jashkenas/underscore.git#^1.8.3
bower underscore#^1.8.3                resolve https://github.com/jashkenas/underscore.git#^1.8.3
bower angular-uuid4#0.3.1           not-cached https://github.com/monicao/angular-uuid4.git#0.3.1
bower angular-uuid4#0.3.1              resolve https://github.com/monicao/angular-uuid4.git#0.3.1
bower vcard#0.2.7                   not-cached https://github.com/Heymdall/vcard.git#0.2.7
bower vcard#0.2.7                      resolve https://github.com/Heymdall/vcard.git#0.2.7
bower jquery-timepicker#883bb2cd94  not-cached https://github.com/fgelinas/timepicker.git#883bb2cd94
bower jquery-timepicker#883bb2cd94     resolve https://github.com/fgelinas/timepicker.git#883bb2cd94
bower angular-cache#4.6.0             download https://github.com/jmdobry/angular-cache/archive/4.6.0.tar.gz
bower angular-bootstrap#1.1.2         download https://github.com/angular-ui/bootstrap-bower/archive/1.1.2.tar.gz
bower ui-select#0.14.9                download https://github.com/angular-ui/ui-select/archive/v0.14.9.tar.gz
bower angular-route#1.5.8             download https://github.com/angular/bower-angular-route/archive/v1.5.8.tar.gz
bower angular-sanitize#1.5.8          download https://github.com/angular/bower-angular-sanitize/archive/v1.5.8.tar.gz
bower underscore#^1.8.3               download https://github.com/jashkenas/underscore/archive/1.13.2.tar.gz
bower ngclipboard#^1.1.1              download https://github.com/sachinchoolur/ngclipboard/archive/1.1.3.tar.gz
bower angular#1.5.8                   download https://github.com/angular/bower-angular/archive/v1.5.8.tar.gz
bower angular-mocks#1.5.8             download https://github.com/angular/bower-angular-mocks/archive/v1.5.8.tar.gz
bower angular-uuid4#0.3.1             download https://github.com/monicao/angular-uuid4/archive/v0.3.1.tar.gz
bower jquery-timepicker#883bb2cd94   short-sha Consider using longer commit SHA to avoid conflicts
bower jquery-timepicker#883bb2cd94    download https://github.com/fgelinas/timepicker/archive/883bb2cd94.tar.gz
bower angular-cache#4.6.0              extract archive.tar.gz
bower angular-bootstrap#1.1.2          extract archive.tar.gz
bower angular-bootstrap#1.1.2         resolved https://github.com/angular-ui/bootstrap-bower.git#1.1.2
bower ui-select#0.14.9                 extract archive.tar.gz
bower ngclipboard#^1.1.1               extract archive.tar.gz
bower angular-uuid4#0.3.1              extract archive.tar.gz
bower angular-sanitize#1.5.8           extract archive.tar.gz
bower angular-route#1.5.8              extract archive.tar.gz
bower angular-mocks#1.5.8              extract archive.tar.gz
bower underscore#^1.8.3                extract archive.tar.gz
bower ngclipboard#^1.1.1              resolved https://github.com/sachinchoolur/ngclipboard.git#1.1.3
bower angular-sanitize#1.5.8          resolved https://github.com/angular/bower-angular-sanitize.git#1.5.8
bower angular#1.5.8                    extract archive.tar.gz
bower clipboard#~1.5.5              not-cached https://github.com/zenorocha/clipboard.js.git#~1.5.5
bower clipboard#~1.5.5                 resolve https://github.com/zenorocha/clipboard.js.git#~1.5.5
bower angular-route#1.5.8             resolved https://github.com/angular/bower-angular-route.git#1.5.8
bower jquery-timepicker#883bb2cd94     extract archive.tar.gz
bower angular-mocks#1.5.8             resolved https://github.com/angular/bower-angular-mocks.git#1.5.8
bower angular-uuid4#0.3.1             resolved https://github.com/monicao/angular-uuid4.git#0.3.1
bower angular-cache#4.6.0             resolved https://github.com/jmdobry/angular-cache.git#4.6.0
bower angular#1.5.8                   resolved https://github.com/angular/bower-angular.git#1.5.8
bower ui-select#0.14.9                mismatch Version declared in the json (0.13.2) is different than the resolved one (0.14.9)
bower ui-select#0.14.9                resolved https://github.com/angular-ui/ui-select.git#0.14.9
bower clipboard#~1.5.5                download https://github.com/zenorocha/clipboard.js/archive/v1.5.16.tar.gz
bower jquery-timepicker#883bb2cd94    resolved https://github.com/fgelinas/timepicker.git#883bb2cd94
bower clipboard#~1.5.5                 extract archive.tar.gz
bower clipboard#~1.5.5                resolved https://github.com/zenorocha/clipboard.js.git#1.5.16
bower underscore#^1.8.3               resolved https://github.com/jashkenas/underscore.git#1.13.2
bower vcard#0.2.7                      ECMDERR Failed to execute "git ls-remote --tags --heads https://github.com/Heymdall/vcard.git", exit code of #128 remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead. remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information. fatal: Authentication failed for 'https://github.com/Heymdall/vcard.git/'

Additional error details:
remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
fatal: Authentication failed for 'https://github.com/Heymdall/vcard.git/'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! contacts@1.5.4 prebuild: `npm install && npm update && node_modules/bower/bin/bower install && node_modules/bower/bin/bower update`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the contacts@1.5.4 prebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-04-19T01_19_39_546Z-debug.log
make: *** [Makefile:120: npm] Error 1
phil-davis commented 2 years ago

https://github.com/Heymdall does not exist on GitHub. Maybe the user deleted their account? Or it has become completely private?

I am looking to see where this is actually referenced in the JS dependencies...

phil-davis commented 2 years ago

https://libraries.io/bower/vcard has links to the various tagged releases https://libraries.io/bower/vcard/tags and those link to GitHub like https://github.com/Heymdall/vcard/releases/tag/v0.2.7 - but those are all gone on GitHub.

@DeepDiver1975 - I see that you are mentioned as a contributor. Do you have any memory about this stuff? Any idea why https://github.com/Heymdall/vcard repo has disappeared?

How do we find a useful fork of this, that has the correct up-to-date code? (And then we could fork it ourselves, and use that to be sure that it does not get lost in future)

DeepDiver1975 commented 2 years ago

I have not touched this app in years. Sorry. No clue what's going on ....

phil-davis commented 2 years ago

I found https://github.com/tncho/vcard - that has the correct v0.2.7 tag. To demonstrate, I forked that to https://github.com/JankariTech/vcard and used the fork in PR #736

That finds the vcard 0.2.7 code and the JS tests pass.

phil-davis commented 2 years ago

https://github.com/Heymdall does not exist any more on GitHub. I found a fork that has the correct latest v0.2.7 tag:

https://github.com/tncho/vcard

@micbar (or whoever) - can we fork that into owncloud/vcard ?

And then it can be used from there. That will avoid having to find a similar maintained library, or other high-impact action, for now.

DeepDiver1975 commented 2 years ago

@micbar (or whoever) - can we fork that into owncloud/vcard ?

alternative: copy the it into this repo - it is actually only one file: https://github.com/tncho/vcard/tree/master/src

phil-davis commented 2 years ago

alternative: copy the it into this repo

I am not familiar with the "layout" of the JS files. I am sure it will be easy to do, but exactly where do I copy the code so that it gets found and called?

phil-davis commented 2 years ago

@micbar or someone - which way do we proceed? Forked repo, or paste the code directly somewhere in this repo?

kiranparajuli589 commented 2 years ago

failed on the recent nightly build too https://drone.owncloud.com/owncloud/contacts/1260

Talank commented 2 years ago

@micbar (or whoever) - can we fork that into owncloud/vcard ?

alternative: copy the it into this repo - it is actually only one file: https://github.com/tncho/vcard/tree/master/src

We can try this out

grgprarup commented 2 years ago

failed in last nightly. build link here: https://drone.owncloud.com/owncloud/contacts/1287

phil-davis commented 2 years ago

We can try this out

@grgprarup @kiranparajuli589 this needs to be assigned to someone, and they can work out where to copy the code into this repo, and how to make it be used after removing the dependency.

phil-davis commented 2 years ago

@micbar (or whoever) - can we fork that into owncloud/vcard ?

alternative: copy the it into this repo - it is actually only one file: https://github.com/tncho/vcard/tree/master/src

PR #738 copied the code into this repo. CI is green again.