search

owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.38k stars 2.06k forks source link

Public sharing broken on master #15913

Closed LukasReschke closed 9 years ago

LukasReschke commented 9 years ago

@icewind1991 While fixing the namespace in https://github.com/owncloud/core/blob/557b4a2cb0ae0367e5facb1e4be136de07ab8cff/apps/files_sharing/appinfo/application.php you broke public sharing in core completely, please take a look at https://github.com/owncloud/core/blob/557b4a2cb0ae0367e5facb1e4be136de07ab8cff/core/routes.php#L111-L126

Regression by the ETag PR from https://github.com/owncloud/core/pull/14764

LukasReschke commented 9 years ago

Wondering if Scrutinizer should have catched that, waiting for analysis as per https://github.com/owncloud/core/pull/14764#issuecomment-96648539

@DeepDiver1975 Anything we can do to catch such stuff on Jenkins?

LukasReschke commented 9 years ago

PR is at https://github.com/owncloud/core/pull/15915

DeepDiver1975 commented 9 years ago

@DeepDiver1975 Anything we can do to catch such stuff on Jenkins?

unit tests

LukasReschke commented 9 years ago

unit tests

Of the routing file? – Long way to go :see_no_evil: