owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.37k stars 2.06k forks source link

Feature request: paste images #17794

Closed szepeviktor closed 3 years ago

szepeviktor commented 9 years ago

It would be nice to paste images to ownCloud like: http://snag.gy/ snaggy includes HTML5 and a Java applet also.

szepeviktor commented 9 years ago

Also: http://ctrlv.in/ and http://pasteboard.co/ which turned out to be open-source https://github.com/JoelBesada/pasteboard

oparoz commented 9 years ago

How is this different than a simple drag and drop?

szepeviktor commented 9 years ago

You have to save a screenshot etc. to a file to be able to drag&drop. Pasting does not need that step. You can even copy an image file and paste it, but that's the same as drag&drop using keyboard only. I don't think it's possible to drag&drop with the keyboard. I'm a keyboard type 'a guy.

oparoz commented 9 years ago

You have to save a screenshot etc. to a file to be able to drag&drop.

You mean instead of doing a "print screen" and then ctrl +v?

szepeviktor commented 9 years ago

Yes.

oparoz commented 9 years ago

Got it.

szepeviktor commented 9 years ago

pasteboard is open-source.

oparoz commented 9 years ago

Yes, but most of it is not needed. The main problem is that it doesn't work on IE, so there is very little chance of it getting integrated (personal opinion). http://caniuse.com/#feat=clipboard

szepeviktor commented 9 years ago

:cry:

szepeviktor commented 9 years ago

Works for me on Win7/IE11 IE11 paste

szepeviktor commented 9 years ago

But this is a Java applet on snaggy that is not open-source.

oparoz commented 9 years ago

But this is a Java applet on snaggy that is not open-source.

Yep, 2 problems. You don't need the applet if pasting text I think, but that's not really useful in a files sharing app.

szepeviktor commented 9 years ago

May there are non-IE users out there.

oparoz commented 9 years ago

Maybe it can be introduced as a feature for non-IE users only. You'll have to wait for other people to voice in their opinion :)

jzee commented 9 years ago

:+1: I believe it would be a huge usability plus!

oparoz commented 9 years ago

@jancborchardt Huge usability plus?

RobinMcCorkell commented 9 years ago

If anything, this should be implemented as an app.

jancborchardt commented 9 years ago

The main problem is that it doesn't work on IE, so there is very little chance of it getting integrated

Stuff like this is ok as enhancement since it’s not a core feature at all.

Regarding the thing itself: Nice addition – not sure if it’s a »huge usability plus« though. Rather a small enhancement for technical people since most folks don’t really use/know Ctrl+V.

If someone wants to have a go at it they can. I’d not say this is something for a separate app since it should be present in files, related to the drag&drop area: https://github.com/owncloud/core/pull/10470

szepeviktor commented 9 years ago

most folks don’t really use/know Ctrl+V

That is shocking for me. It is the second most basic key combination on all PC-s, after Ctrl-C.

Please consider a UI which emphasis Ctrl-V, see: https://github.com/owncloud/core/issues/17794#issuecomment-123504113

jancborchardt commented 9 years ago

most folks don’t really use/know Ctrl+V

That is shocking for me.

Well, 90% of American internet users don’t know about Ctrl-F (2010). Remember that we discussing on issue trackers are a technical minority.

jzee commented 9 years ago

Are you designing a system for 90% of American internet users in 2010? :)

jancborchardt commented 9 years ago

@jzee not sure how the remark is relevant. What I meant was that this is certainly a feature low in priority since for the majority of people it’s basically invisible. @szepeviktor @jzee you are very welcome to take a stab at it and submit a pull request.

jzee commented 9 years ago

@jancborchardt that was a joking attempt at pointing out that the facts you were pulling are out of date and that I question whether that's true. and that just because it might have been true 5 years ago, it would still be a huge usability plus for me.

Having said that, I just learned that you seem to be responsible for usability at OC, so have it your way.

My 2c are that any site with a good reputation for usability does have proper keyboard shortcuts.

Trello https://trello.com/shortcuts Twitter https://twitter.com/perform/status/350980645872345088 GMail https://support.google.com/mail/answer/6594?hl=en Facebook https://www.facebook.com/help/156151771119453 Instagram https://help.instagram.com/help/www/147441522071668 Outlook Webapp https://support.office.com/en-sg/article/Keyboard-shortcuts-in-Outlook-Web-App-63df572e-1078-4562-b45e-b93e07a76ffb

etc.

szepeviktor commented 9 years ago

Well, 90% of American internet users don’t know about Ctrl-F (2010).

That makes a developer refrain from coding.

jancborchardt commented 9 years ago

@jzee as said: pull requests are very welcome. :) I’m just saying that if you’re »asking« for the feature and want to wait for »us« to implement, then it will take some time.

oparoz commented 9 years ago

@jzee - Lots of the site you've mentioned allows shortcuts, yes, put not many offer ctrl+v to paste images.

jzee commented 9 years ago

@oparoz - oh yeah. I was arguing for the usefulness of proper keyboard shortcuts as my impression had been that jcb dismissed them as "low priority".

I believe that they differentiate well-designed systems from systems that appear to be stitched together. And I personally know how much pain it can mean to add hotkeys late in a system design instead of including them systematically early on.

jancborchardt commented 9 years ago

I was arguing for the usefulness of proper keyboard shortcuts as my impression had been that jcb dismissed them as "low priority".

@jzee no. I was just referring to the topic of this specific issue, the ability to paste stuff using Ctrl-V. Unlike simpler keyboard shortcuts this probably takes a significant amount of code.

jzee commented 9 years ago

@jancborchardt - for the sake of argument and tongue-in-cheek: is that so? :)

http://stackoverflow.com/a/6338207

Anyway, I don't want to go out on that limb too far and I need to say that I respect the work that you guys are doing to make OC work so well on different browsers and platforms so once again thanks for your good work!

EDIT: it's also working very well for me using Safari & FF with the web-client of telegram.org, the messaging service. There I found it to be a usability plus. They appear to have the whole clipboard sending implemented very smoothly.

szepeviktor commented 9 years ago

this probably takes a significant amount of code.

Which is already in production. See pasteboard above.

jancborchardt commented 9 years ago

@jzee @szepeviktor cool that you already found the relevant code. :) Now it’s only a small step for you to implement it and submit a pull request.

PVince81 commented 8 years ago

Shouldn't this rather be implemented as a separate app ? Or is this an extension for the files app ?

jancborchardt commented 8 years ago

Depends on how much code this is. Because this is just a small feature and not really an app, people are unlikely to install this – however it might be useful & nice for more experienced folks.