owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.4k stars 2.05k forks source link

can't update daily to daily, version number broken? #18880

Closed jospoortvliet closed 8 years ago

jospoortvliet commented 9 years ago

Sooh, I can't upgrade the daily snapshot to a newer daily snapshot - version of that seems '100.0.0.0' or something. I can upgrade to 'stable' (which is newer than my snapshot, indeed) but then I'm stuck. Beta is also on 100.0.0.0...

upgrade

The video shows it all, at a very low resolution to save you bandwidth ;-)

karlitschek commented 9 years ago

@VicDeo Any idea? Maybe I did something wrong with the versions of the daily builds?

VicDeo commented 9 years ago

@karlitschek yep.. there is a check that prevents from migration from 6 to 8 directly. the same with migration from 8.1 to 100.0

jospoortvliet commented 9 years ago

Perhaps version 100.0 should be special-cased. Or, to allow updating to newer versions of the daily built we'll need the version number to increment from 100.0.000 to 100.0.001 and so on, every day... ?

Not sure who made the built scripts behind the daily packages. You, @VicDeo ?

VicDeo commented 9 years ago

@jospoortvliet not me. I can just skip this check for daily builds at all.

karlitschek commented 9 years ago

Maybe the best soltion is to skip the check for 100 aka. daily build. I hope the rest of the logic is correct

jospoortvliet commented 9 years ago

@VicDeo ah, that would be perfectly fine. Also be sure to always allow updating to a newer version (there is one once a day after all) because if the version in daily is always 100.0, the updater might decide you're on the latest version - always.

MorrisJobke commented 9 years ago

@VicDeo What is the status of this?

VicDeo commented 9 years ago

@MorrisJobke status is haven't looked at due to no milestone and severity

VicDeo commented 9 years ago

@jospoortvliet please replace your updater with this one https://github.com/owncloud/updater/archive/fix-injection.zip

PR pending https://github.com/owncloud/updater/pull/179

VicDeo commented 9 years ago

By the way, daily is packed using bz2 compression and https://github.com/owncloud/core/pull/19182 is set to 9.0

Which means that you won't be able to upgrade daily anyway Symptoms are the same with described in the https://github.com/owncloud/core/pull/19182 :

Unsupported compression type 'bz'
Supported types are 'gz', 'bz2' and 'lzma2'.
Unable to open in read mode
VicDeo commented 9 years ago

cc @karlitschek

PVince81 commented 9 years ago

@VicDeo is this fixed by your PR ?

PVince81 commented 9 years ago

@jospoortvliet are you still seeing this with the latest dailies ?

VicDeo commented 9 years ago

Current status: I. all OC versions including master know nothing about bz2 extension which makes OC_Archive fail on extraction bz2 Null is returned as a mimetype at this point for bz2 extension https://github.com/owncloud/core/blob/master/lib/private/archive.php#L40 Solution: add bz2 to known mimetypes "bz2": ["application/x-bzip2"], to mimetypemapping.dist.json

II. 8.2.x and below need owncloud/core@a543d20 because bz2 support is broken for these versions.

MorrisJobke commented 9 years ago

Solution: add bz2 to known mimetypes

Can you create a PR (and don't forget to increase the version number and add the repair step)

PVince81 commented 8 years ago

Any update ?

VicDeo commented 8 years ago

@PVince81 this particular issue is not relevant to 9.x because new updater doesn't rely on OC_Archive any more. OC_Archive fix is pushed in https://github.com/owncloud/core/issues/22875

VicDeo commented 8 years ago

Can be closed since all channels ship zip packages now.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.