owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.39k stars 2.05k forks source link

Pending file mimetypes to be fixed. #19573

Closed SergioBertolinSG closed 3 years ago

SergioBertolinSG commented 9 years ago

Interpreted as plain text but its document:

Interpreted as plain text but is code:

Not interpreted at all:

nickvergessen commented 9 years ago

Btw opening the files is nothing that is fixed in core.

rullzer commented 9 years ago

@SergioBertolinSG do you have proper mimetypes for all those extentions?

SergioBertolinSG commented 9 years ago

Having them as text/plain or similar but showing a code icon would be enough.

The main problem I see is all those files cannot be opened or edited with text_fileseditor because they are not detected as text.

Except rtf which should be one of this, but not sure which can be handled by the documents app. .rtf application/rtf .rtf application/x-rtf .rtf text/richtext

ghost commented 9 years ago

The main problem I see is all those files cannot be opened or edited with text_fileseditor because they are not detected as text.

Which is weird, exporating these lines (for sql). Should they all be added to the oc_mimetypes table (assuming oc_ as prefix) as text? editor.js#L464 ext-modelist.js#L115

Liquidream commented 8 years ago

I'm having the same problem in my 9.0.2 installation, where *.cs files (and others) are not opening in the text editor (nor do they have appropriate icons).

Is this still a pending update or do I have to configure this somewhere myself?

Thanks!

PVince81 commented 7 years ago

Is this still an issue with 9.1.4 ?

SergioBertolinSG commented 7 years ago

It is still an issue in master.

ghost commented 7 years ago

Indeed, fix would be much appreciated.

PVince81 commented 7 years ago

I don't fully understand the problem here. Is the problem that new mimetypes were introduced but there are old files in oc_filecache still with the old mime type ? If yes, this might be related to https://github.com/owncloud/core/issues/24629.

If not, then please explain in more detail.

Does uploading a new file with the mimetypes above correctly set their mime type ? Maybe these are missing in the mimetype definition file here https://github.com/owncloud/core/blob/master/resources/config/mimetypemapping.dist.json ?

If the latter, then if you have time you could submit a PR that adds the missing ones.

SergioBertolinSG commented 7 years ago

This particular issue is not related with https://github.com/owncloud/core/issues/24629.

They are just missing.

PVince81 commented 7 years ago

Ok, tagging as junior job.

If someone has time for this, please step up and submit a PR.

ownclouders commented 6 years ago

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

ownclouders commented 6 years ago

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

stale[bot] commented 3 years ago

This issue has been automatically closed.