search

owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.37k stars 2.06k forks source link

`Call to a member function acquireLock() on null` during installation #21657

Closed pellaeon closed 8 years ago

pellaeon commented 8 years ago

in /var/www/html/owncloud/lib/private/files/view.php on line 1838

Steps to reproduce

  1. clone the owncloud core repo, cd into it
  2. git submodule init, git submodule update
  3. visit setup page, fill in MySQL/MariaDB database credentials
  4. submit
  5. it shows a blank page, in Apache error log: PHP Fatal error: Call to a member function acquireLock() on null in /var/www/html/owncloud/lib/private/files/view.php on line 1838

    Version

    • Ubuntu 14.04
    • ownCloud master eac5d9fb3a52932fafdb200a2cf5d50fe9f1c759
    • PHP 5.6.17
    • 5.5.46-MariaDB
PVince81 commented 8 years ago

Works for me with my usual checkout on the same commit and also latest master.

Did you also git clone any apps ?

PVince81 commented 8 years ago

More info in this duplicate ticket https://github.com/owncloud/core/issues/21674 (nginx)

PVince81 commented 8 years ago

@icewind1991 can you have a look ?

@mmattel @pellaeon are you able to bisect the issue to find which commit introduced this issue ?

PVince81 commented 8 years ago

@LukasReschke is this similar to the install issue you found on master ? https://github.com/owncloud/core/issues/21669

LukasReschke commented 8 years ago

Different error message but likely to be the same due to the view instantiation.

mmattel commented 8 years ago

I did not clone any apps, only cloning core including submodules

mmattel commented 8 years ago

I just did the following:

sudo git log
[sudo] password for xxxx: 

commit eac5d9fb3a52932fafdb200a2cf5d50fe9f1c759
Merge: 2493cfe 0d0377e
Author: Thomas Müller <thomas.mueller@tmit.eu>
Date:   Tue Jan 12 15:01:46 2016 +0100

    Merge pull request #21336 from owncloud/system-root-certs

    Allow admins to add system wide root certificates

commit 2493cfede92c472c29cffc098206b8cdb7a2ca30
Merge: 4fc0fbe 8b6b042
Author: Thomas Müller <thomas.mueller@tmit.eu>
Date:   Tue Jan 12 14:46:09 2016 +0100

    Merge pull request #21640 from owncloud/add-config-to-disable-wellknown-chec

    Add config switch to disable the .well-known URL check

and checked out the commit previous the suspected one

sudo git checkout 2493cfede92c472c29cffc098206b8cdb7a2ca30

voila --> works, the installation completed sucessfully. Seems that #21336 (Allow admins to add system wide root certificates) causes the problem.

@PVince81 @LukasReschke @icewind1991

icewind1991 commented 8 years ago

Did you test it with https://github.com/owncloud/core/pull/21671?

mmattel commented 8 years ago

I just prepared the environment and cloned from master again which includes #21671 (merged). This time the installation passed without any problems. Thanks @LukasReschke for the fix. :+1:

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.