owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.38k stars 2.06k forks source link

Admin page down after update to 9.0 #22960

Closed tuxmaster closed 8 years ago

tuxmaster commented 8 years ago

After update to 9.0 the admin page are down. Only an white page will show. OS: CentOS7 Log(journal): {PHP} Can't use method return value in write context at /var/www/html/owncloud/apps/files_external/lib/google.php#268

LukasReschke commented 8 years ago

Can you fill out the whole issue template? THX.

LukasReschke commented 8 years ago

Ok. Damn. it's https://github.com/owncloud/core/commit/075dd54f6c4633237e2eef5fe808632c591aef4b

LukasReschke commented 8 years ago

@karlitschek @cmonteroluque @PVince81 This means that Google Drive integration is broken under PHP 5.4

tuxmaster commented 8 years ago

Temporary to get the site back: runuser -s /bin/bash - apache -c "/var/www/html/owncloud/occ app:disable files_external"

LukasReschke commented 8 years ago

@tuxmaster Could you test the patch from https://github.com/owncloud/core/pull/22961?

tuxmaster commented 8 years ago

Yes it will fix it. After apply it, I call runuser -s /bin/bash - apache -c "/var/www/html/owncloud/occ app:enable files_external" An I can use the admin page.

LukasReschke commented 8 years ago

Also a duplicate of #22958

Different issue probably. empty on arbitrary expressions works with PHP 5.5, #22958 uses PHP 5.5. See also http://php.net/manual/en/migration55.new-features.php :)

nickvergessen commented 8 years ago

Should set up a lint task that checks for php 5.4 compatibility on CI? This is the 3+ time we have this exact message

PVince81 commented 8 years ago

Does scrutinizer do that ?

LukasReschke commented 8 years ago

Does scrutinizer do that ?

No. But we could run PHPStorm once before the release. It's analyzer can do that :see_no_evil:

nickvergessen commented 8 years ago

Well we can do it on travis: https://github.com/owncloud/core/pull/22994 or we do something similar on jenkins (multiple checks, instead of only one red mark)

jacob-israel commented 8 years ago

Hello ,

Im having the same problem enabling external storage and then getting admin blank page om OWC 9 , someone could tell me where can I update google lib php files ?

thanks in advance

Jacob

ghost commented 8 years ago

@j-c-dando Just update to oC 9.0.1: https://owncloud.org/blog/owncloud-9-0-1-available/

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.