owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.34k stars 2.05k forks source link

Code integrity fails on update to 9.0.3 with README.md and CONTRIBUTING.md #25414

Closed JochenHWezel closed 8 years ago

JochenHWezel commented 8 years ago

Ubuntu is installed and upgraded using the apt-get upgrade way on my ubuntu 16.04.

This is the list of failures:

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- files_antivirus
    - EXTRA_FILE
        - README.md
        - CONTRIBUTING.md

Raw output
==========
Array
(
    [files_antivirus] => Array
        (
            [EXTRA_FILE] => Array
                (
                    [README.md] => Array
                        (
                            [expected] => 
                            [current] => d197f4b4e0a845261162fdc8ad5a500e579c68c9306471558da14eb3474b70889772fd88fea1161be341421c4dba3bbc63c5e85a8378b38a75d76dbdb1e3264a
                        )

                    [CONTRIBUTING.md] => Array
                        (
                            [expected] => 
                            [current] => 0de5eddd29b6be1a62c71bf217edf2c5b163916842f9976326d5254e14853fc138692ede064994a934cc911b0cd42a502db20e7be0f867af9a4c631a61ace4dc
                        )

                )

        )

)

This is README.md:

root@web01:/var/www/owncloud# cat apps/files_antivirus/README.md
#ownCloud Antivirus App

files_antivirus is an antivirus app for [ownCloud](https://github.com/owncloud) based on [ClamAV](http://www.clamav.net).

##Details

The idea is to check for virus at upload-time, notifying the user (on screen and/or email) and
remove the file if it's infected.

## QA metrics on master branch:

[![Build Status](https://travis-ci.org/owncloud/files_antivirus.svg?branch=master)](https://travis-ci.org/owncloud/files_antivirus/branches)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=master)
[![Code Coverage](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=master)

## QA metrics on stable8 branch:

[![Build Status](https://travis-ci.org/owncloud/files_antivirus.svg?branch=stable8)](https://travis-ci.org/owncloud/files_antivirus/branches)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/quality-score.png?b=stable8)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=stable8)
[![Code Coverage](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/coverage.png?b=stable8)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=stable8)

##Status

The App is not complete yet, the following works/is done:
* It can be configured to work with the executable or the daemon mode of ClamAV
* If used in daemon mode it can connect through network- or local file-socket
* In daemon mode, it sends files to a remote/local server using INSTREAM command
* When the user uploads a file, it's checked
* If an uploaded file is infected, it's deleted and a notification is shown to the user on screen and an email is sent with details.
* Tested in Linux only
* Background Job to scan all files

##In progress

* Test uploading from clients

##ToDo

* File size limit
* Configurations Tuneups
* Other OS Testing
* Look for ideas :P

## Requirements

* ownCloud 7
* ClamAV (Binaries or a server running ClamAV in daemon mode)

## Install

* Install and enable the App
* Go to Admin Panel and configure the App

Authors:

[Manuel Delgado López](https://github.com/valarauco/) :: manuel.delgado at ucr.ac.cr
[Bart Visscher](https://github.com/bartv2/)
root@beiweb01:/var/www/owncloud# clear
root@beiweb01:/var/www/owncloud# cat apps/files_antivirus/README.md
#ownCloud Antivirus App

files_antivirus is an antivirus app for [ownCloud](https://github.com/owncloud) based on [ClamAV](http://www.clamav.net).

##Details

The idea is to check for virus at upload-time, notifying the user (on screen and/or email) and
remove the file if it's infected.

## QA metrics on master branch:

[![Build Status](https://travis-ci.org/owncloud/files_antivirus.svg?branch=master)](https://travis-ci.org/owncloud/files_antivirus/branches)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=master)
[![Code Coverage](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=master)

## QA metrics on stable8 branch:

[![Build Status](https://travis-ci.org/owncloud/files_antivirus.svg?branch=stable8)](https://travis-ci.org/owncloud/files_antivirus/branches)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/quality-score.png?b=stable8)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=stable8)
[![Code Coverage](https://scrutinizer-ci.com/g/owncloud/files_antivirus/badges/coverage.png?b=stable8)](https://scrutinizer-ci.com/g/owncloud/files_antivirus/?branch=stable8)

##Status

The App is not complete yet, the following works/is done:
* It can be configured to work with the executable or the daemon mode of ClamAV
* If used in daemon mode it can connect through network- or local file-socket
* In daemon mode, it sends files to a remote/local server using INSTREAM command
* When the user uploads a file, it's checked
* If an uploaded file is infected, it's deleted and a notification is shown to the user on screen and an email is sent with details.
* Tested in Linux only
* Background Job to scan all files

##In progress

* Test uploading from clients

##ToDo

* File size limit
* Configurations Tuneups
* Other OS Testing
* Look for ideas :P

## Requirements

* ownCloud 7
* ClamAV (Binaries or a server running ClamAV in daemon mode)

## Install

* Install and enable the App
* Go to Admin Panel and configure the App

Authors:

[Manuel Delgado López](https://github.com/valarauco/) :: manuel.delgado at ucr.ac.cr
[Bart Visscher](https://github.com/bartv2/)
root@web01:/var/www/owncloud#

This is CONTRIBUTING.md:

root@web01:/var/www/owncloud# cat apps/files_antivirus/CONTRIBUTING.md
## Submitting issues

If you have questions about how to install or use ownCloud, please direct these to the [mailing list][mailinglist] or our [forum][forum]. We are also available on [IRC][irc].

### Short version

 * The [**issue template can be found here**][template]. Please always use the issue template when reporting issues.

### Guidelines
* Please search the existing issues first, it's likely that your issue was already reported or even fixed.
  - Go to one of the repositories, click "issues" and type any word in the top search/command bar.
  - You can also filter by appending e. g. "state:open" to the search string.
  - More info on [search syntax within github](https://help.github.com/articles/searching-issues)
* This repository ([files_antivirus](https://github.com/owncloud/files_antivirus/issues)) is *only* for issues within the ownCloud files_antivirus code.
* __SECURITY__: Report any potential security bug to security@owncloud.com following our [security policy](https://owncloud.org/security/) instead of filing an issue in our bug tracker
* Report the issue using our [template][template], it includes all the information we need to track down the issue.

Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues.

[template]: https://raw.github.com/owncloud/core/master/issue_template.md
[mailinglist]: https://mailman.owncloud.org/mailman/listinfo/owncloud
[forum]: https://forum.owncloud.org/
[irc]: https://webchat.freenode.net/?channels=owncloud&uio=d4

### Contribute Code and translations
Please check [core's contribution guidelines](https://github.com/owncloud/core/blob/master/CONTRIBUTING.md) for further information about contributing code and translations.
root@web01:/var/www/owncloud#

I expect these files to be a "false alert".

ghost commented 8 years ago

@JochenHWezel Seems some leftovers of a older or manual installed version of the files_antivirus. You can close here and follow the instruction from:

https://doc.owncloud.org/server/9.0/admin_manual/issues/code_signing.html#fixing-invalid-code-integrity-messages

Removing both files and running a rescan should solve this.

DeepDiver1975 commented 8 years ago

@jnweigert can you please check the packages if by accident these two files got added? Thx

PVince81 commented 8 years ago

@jnweiger

jnweiger commented 8 years ago

dpkg -L owncloud-enterprise-files | grep files_antivirus | grep md

returns nothing and I don't have these two files on my test installations. These two files are not part of the packages. I'd go with @RealRancor and assume they are leftovers.

@JochenHWezel To check if it comes from an owncloud package, you can try

apt-get install apt-file
apt-file update
apt-file search CONTRIBUTING.md | grep owncloud

Please reopen, if it does.

JochenHWezel commented 8 years ago

no files found in apt-file, except:


owncloud-client: /usr/share/doc/owncloud-client/README.md

So, it seems to be a left-over from the initial install with 9.0.0 or 9.0.1 (don't remember any more) from either install script or from apt-get installation or both (one after the other one) or similar.

For now and for my personal environment, I'll delete these 2 files.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.