owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.38k stars 2.06k forks source link

OneNote 2016 needs a different user agent string #30962

Closed mmattel closed 6 years ago

mmattel commented 6 years ago

Issue: Webdav relevant. The user agent strings for Microsoft OneNote 2013 and 2016 are different.

For 2013 it is: (already implemented) /Microsoft Office OneNote 2013/

For 2016 it is: /OneNote/

Reference: Please see: https://www.webmasterworld.com/search_engine_spiders/4851195.htm and https://answers.microsoft.com/en-us/msoffice/forum/msoffice_onenote-mso_win10/onenote-2016-authentication-issue-with-on-premises/1e136b4f-70b2-4f19-a636-4b14e5972bd8 Quote: "...OneNote 2016 user agent string starts with OneNote… "

Solution: User agent string to be added at: https://github.com/owncloud/core/blob/92b658a60e6c28ef9dd7594384180e0d73e96660/apps/dav/lib/Connector/Sabre/ServerFactory.php#L117 and https://github.com/owncloud/core/blob/a32d5dd211aab20912929faa064809792644f09c/apps/dav/lib/Server.php#L179

Note: Looks like that Microsoft is removing any year or vendor info to be open for upcoming releases.

ownclouders commented 6 years ago

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are https://github.com/owncloud/core/issues/7370 (User Agent Strings), https://github.com/owncloud/core/issues/27813 (Need the ability to list users), https://github.com/owncloud/core/issues/563 (String Error?), https://github.com/owncloud/core/issues/4055 (File Versioning needs User identifier), and https://github.com/owncloud/core/issues/1333 (rename users).

DeepDiver1975 commented 6 years ago

@mmattel please submit a PR - we can easily merge and backport this. THX a lot!

mmattel commented 6 years ago

closin, corresponding PRs are merged

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.