search

owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.38k stars 2.06k forks source link

Edge webUI Personal Settings tests report not getting to that page #31021

Open phil-davis opened 6 years ago

phil-davis commented 6 years ago

Edge Personal Settings tries to go to the personal settings page, and often complains:

  Scenario: New password is same as current password                                                                                        # /home/[secure]/build/owncloud/core/tests/acceptance/features/webUIPersonalSettings/changePasswordFromSetting.feature:24
    And the user has browsed to the personal general settings page                                                                          # WebUIPersonalGeneralSettingsContext::theUserBrowsesToThePersonalGeneralSettingsPage()
      exception 'SensioLabs\Behat\PageObjectExtension\PageObject\Exception\UnexpectedPageException' with message 'Expected to be on "http://owncloud:8889/index.php/settings/personal?sectionid=general" but found "http://owncloud:8889/index.php/apps/files/?dir=/&fileid=249" instead' in /home/[secure]/build/owncloud/core/lib/composer/sensiolabs/behat-page-object-extension/src/SensioLabs/Behat/PageObjectExtension/PageObject/Page.php:217

Looking at the SauceLabs video, the browser does get to the requested page. So it seems that something in the Edge webdriver is causing the check for having arrived at the correct page to look too early, or have stale state information or...

This has never been seen when running the tests on chrome, firefox or IE11.

ownclouders commented 6 years ago

GitMate.io thinks possibly related issues are https://github.com/owncloud/core/issues/22485 (test), https://github.com/owncloud/core/issues/22492 (test), https://github.com/owncloud/core/pull/30632 (Wait for personal general settings page to load), https://github.com/owncloud/core/issues/6521 (Can't edit personal settings...), and https://github.com/owncloud/core/pull/30634 ([stable10] wait for personal general settings page to load).

phil-davis commented 6 years ago

Yes, #30632 did stuff related to this for Edge. The problem here happens "inside" the provided method that goes to the page. That method does a check itself that it reached the page, and it is that check that fails intermittently. We might need to browse more "manually" to the page and then wait ourselves until it "comes".

ownclouders commented 6 years ago

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

ownclouders commented 6 years ago

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

phil-davis commented 4 years ago

Removed my assignment. Someone will notice this again some day if/when we try to run the automated UI acceptance tests with Edge.