search

owncloud / core

:cloud: ownCloud web server core (Files, DAV, etc.)
https://owncloud.com
GNU Affero General Public License v3.0
8.36k stars 2.06k forks source link

10.0.8RC1/2/3 - Changelog Testing #31098

Closed patrickjahns closed 6 years ago

patrickjahns commented 6 years ago

Changelog for 10.0.8. Summary

Summary of the complete Changelog: https://github.com/owncloud/core/blob/stable10/CHANGELOG.md

This summary has a QA purpose.

Added

patrickjahns commented 6 years ago

Changed

Library updates

patrickjahns commented 6 years ago

Fixes

patrickjahns commented 6 years ago

Removed

IljaN commented 6 years ago

To test checksum repair command, upload a file and then manually modify checksum column in oc_filecache to something else.

More notes here: https://github.com/owncloud/documentation/issues/4014

patrickjahns commented 6 years ago

⚠️ Critical / Auth / Security related ⚠️

Fixxed

DeepDiver1975 commented 6 years ago

Removed private oc_current_user Javascript variable - #30486 #30556

We had a regression in calendar which was resolved already https://github.com/owncloud/calendar/pull/884

patrickjahns commented 6 years ago

@DeepDiver1975 @PVince81 Can we put this in "developer" release notes - so third party developers will know about this change ?

pako81 commented 6 years ago

@patrickjahns Tested:

Fix validation for new encryption storage key location - #30357

Works perfectly. Please go ahead and tick the checkbox

jvillafanez commented 6 years ago

Added repair step to fix orphaned reshares

Currently untested with oracle... any chance to test it with it? I haven't found easy support to test it with oracle. I'm marking as passed as it works fine for mysql and postgresql, although the performance looks scary for large datasets on first sight. I'm not sure how fast it will behave or if we can do something about it.

patrickjahns commented 6 years ago

@jvillafanez docker run -p 1521:1521 deepdiver/docker-oracle-xe-11g - then you have oracle.

If you need a container with oracle php modules - you can use https://hub.docker.com/r/owncloudci/php/tags

Note:

with the oracle container above - database username is autotest - database password is owncloud and database is XE - ref: https://github.com/owncloud/core/blob/master/tests/drone/install-server.sh

PVince81 commented 6 years ago

Can we put this in "developer" release notes - so third party developers will know about this change ?

This was never supposed to be public API but people still used this.

We can add a note in the regular release notes as we don't have developer release notes.

PVince81 commented 6 years ago

Tested "Fixed regression where a user could not set own email address in the settings page - #30319"

PVince81 commented 6 years ago

Tested "Set empty authtoken names to 'none' as empty is not allowed any more - #30908"

PVince81 commented 6 years ago

Ticked "Added config.php option to select apps to ignore missing signature file (mostly for themes)" as Confirmed by @thommierother https://github.com/owncloud/core/pull/30891#issuecomment-381077539

PVince81 commented 6 years ago

Tested "Guide users to also check spelling for typos in federated share id - #30355" => with failure: no_entry missing code path #30159 (comment) (would consider "known issue" as it's minor)

PVince81 commented 6 years ago

Tested "Added user:modify command to core - #30652" => works changing display name and email

PVince81 commented 6 years ago

Tested "Fix failure of shares which are already moved with transfer ownership - #30161", not working 100% as expected, raised bug https://github.com/owncloud/core/issues/31150

mmattel commented 6 years ago

Added: Configurable minimum characters before autocomplete user searches https://github.com/owncloud/core/pull/30798

PVince81 commented 6 years ago

Found bug "Public link share name length check is inaccurate": https://github.com/owncloud/core/issues/31157

IljaN commented 6 years ago

Tested: Better label for CORS in settings section - #30663 -> OK!

IljaN commented 6 years ago

Tested: Allow regular users to change their CORS domains - #30649 -> OK!

Tested by setting custom Origin header in curl for ocs requests. If origin matched the whitelisted origin, correct CORS headers are present. CORS-Whitelists are isolated between different users.

IljaN commented 6 years ago

Tested: Adding a system configuration for global CORS domains - #30906 -> OK!

IljaN commented 6 years ago

Tested: Fix CORS OPTIONS request for unauthenticated requests - #30912 -> OK!

OPTIONS with "Access-Control-Request-Method" header returns 200 on un-authenticated ocs-api request.

PVince81 commented 6 years ago

Failed Test "Make theming work when theme app is outside the ownCloud root - #30477" and failed, raised https://github.com/owncloud/core/issues/31170

PVince81 commented 6 years ago

Added "regression test retention / trashbin expiration" checkbox as the fix of the matching item moves more code around and does more than just fixing the issue.

IljaN commented 6 years ago

Tested: Keep null in getMetaData in Checksum storage wrapper, fixes some files:scan scenarios #30302 -> OK!

Filescan does not crash on unreadable local and ext-storage files.

IljaN commented 6 years ago

Tested: Fixing logout for app password scenario - #30591 -> OK!

No login failed messages in log when logging in with app password.

@voroyam Can you please test app-password login in combination with ldap? No "Login-Failed" Messages should appear in the log.

IljaN commented 6 years ago

Added "test app-pasword login with ldap"

PVince81 commented 6 years ago

Missing items and items to add since RC1:

10.0.8 RC2 items

Added

Changed

Fixes

IljaN commented 6 years ago

Tested: Fix some CSRF issues on Webdav endpoint by only checking for POST method - #30358 -> OK!

PROPFIND via Postman works without CSRF-Token

patrickjahns commented 6 years ago

Testing "Do not log errors when uploading forbidden file format"

❌

Tested with files_antivirus master:

Behavior with old antivirus-app: 10.0.8RC3 + files_antivirus from marketplace image

10.0.7 + files_antivirus from marketplace image

PVince81 commented 6 years ago

Tested "Make syslog output configurable, introduce new default that includes the request id ", works

patrickjahns commented 6 years ago

Testing: Added config switch to enable fallback to http scheme when creating fed shares

Receiving side just sees this error message when going via http image

PVince81 commented 6 years ago

Failed: Files app UI now retries chunk uploads in web UI on stalled uploads, will be reverted: https://github.com/owncloud/core/pull/31185

PVince81 commented 6 years ago

Retested "Make theming work when theme app is outside the ownCloud root - #30477", works in RC3

PVince81 commented 6 years ago

Notifications items to test

From https://github.com/owncloud/notifications/pull/180

PVince81 commented 6 years ago

Tested "Properly trigger file-related Symfony events when chunking" with old chunking, new chunking and no chunking: events are triggered

IljaN commented 6 years ago

Tested "Use storage specific move operation for object store - #30817" => OK!

SergioBertolinSG commented 6 years ago

Retested Fix App Framework ApiContoller initialization to fix thumbnail access - #31104 - @SergioBertolinSG #29914 (comment) Not working in RC2, Works in RC3.

pako81 commented 6 years ago

Tested "regression test retention / trashbin expiration" - works fine (at least no regression). Need however to clarify what is the expected behavior about the min retention period. Will open a separate issue for that.

PVince81 commented 6 years ago

Failed: "Added config switch to enable fallback to http scheme when creating fed shares - #30646", tested by @DeepDiver1975. It seems the code is not triggered / the fix is in the wrong location.

@DeepDiver1975 will fix it. Ticket: https://github.com/owncloud/core/issues/31194

IljaN commented 6 years ago

Tested: Catch session unavailable exception - #30347 #30623 -> OK!

Additional codereview because hard to reproduce, automated tests should be enough

jvillafanez commented 6 years ago

❗️ Confusing behaviour with single user syncing if the user doesn't exists (Ticket opened in https://github.com/owncloud/core/issues/31207 for 10.0.9)

root@3b450a98bad4:/opt/owncloud# sudo -u www-data ./occ user:sync -u miimi "OC\User\Database"
If unknown users are found, what do you want to do with their accounts? (removing the account will also remove its data)
  [0] disable
  [1] remove
  [2] ask later
 > 2
Syncing miimi ...
These accounts that are no longer available in the backend:
miimi, ,  (no longer exists in the backend)
What do you want to do with their accounts? (removing the account will also remove its data)
  [0] disable
  [1] remove
 > 0
Disabling accounts
miimi, ,  (no longer exists in the backend)

From a behavioural point of view, this doesn't look good. Asking first what to do was thought in order to sync a large number of users so you can set the appropiate action before start the syncing. With just one user this seems a bit pointless. What really bothers me is that we should know at some point that the account doesn't exists. Asking what to do with a missing account is pointless, and then disabling or removing a missing account is misleading.

I'm not sure if there is an easy enough fix for this to include it in 10.0.8. Otherwise we'll likely have to delay the solution for 10.0.9.

PVince81 commented 6 years ago

10.0.8 RC4 items to test

patrickjahns commented 6 years ago

-> tested "Prevent background scan to scan homes of users who never logged in" tested during other test -> message not appearing

patrickjahns commented 6 years ago

Tested "Federation fallback to http config switch" -> works as expected

PVince81 commented 6 years ago

RC testing is done, thanks a lot everybody for the big effort!

final smoke test here: https://github.com/owncloud/core/issues/31096#issuecomment-382798088

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.