Closed johnwayne4d closed 3 years ago
as a use case, say in my main directory i created a folder each for tom, dick, and harry - named accordingly. now in each of those named subfolders, i create a subfolder exactly named "user uploads". so tom has a "user uploads", dick has a "user uploads", and so on. now i create shares of each of the separate subfolders which are each named "user uploads". but now let's say that dick left the project, so i go to "all files" and click the category for "shared by link" in an effort to remove the share. i need to navigate to details in order to see which of the identically named subfolder results in this category was for dick. As soon as details opens on the far-right, the other matching results in the category disappear. which is the problem.
GitMate.io thinks possibly related issues are https://github.com/owncloud/core/issues/22295 (Possibility of 'invisible' link shares), https://github.com/owncloud/core/issues/15022 (Share link hangs), https://github.com/owncloud/core/issues/5719 (sending share email link fails), https://github.com/owncloud/core/issues/31427 (some files with bad signature error), and https://github.com/owncloud/core/issues/30156 (Federation sharing options missing).
Confirmed in current core master
1) Share different folders that have the same name, e.g. upload-folder
2) Have other folders shared, if you like
3) Go to "Shared with others"
4) See all the separate entries listed for upload-folder
and each of has "Shared with Dick" "Shared with Tom"... on its file row
5) Click to display the sharing details of 1 of the upload-folder
items.
a) The details of the first upload-folder
are always shown (e.g. "Shared with Dick")
b) The file rows of the other upload-folder
entries disappear
Same behavior in 10.0.8.5
and 10.0.9.2
This is a general problem with views of the file list that can contain multiple files/folders with the same name. e.g.:
1) Favorite each of the upload-folder
above.
2) Go to "Favorites" and see the 3 upload-folder
items listed
3) Open the sharing panel for 1 of them
The details of the top one are displayed, the other entries in the file list disappear.
Wash, rinse, repeat by tagging all the upload-folder
and going to "Tags" and filter on the tag.
Make public links for such folders, go to "Shared by link", it's all the same issue...
When opening the share panel, it loads the shares from the server and then based on state, triggers an event back to the file list to tell it what icon to use. (anchor for local share, planet for public link) It is possible that the code that tries to update the single row somehow deletes all other rows... That code should be adjusted to not search by name but by file id.
(and in general the whole file list needs a good rewrite as it's messy, see https://github.com/owncloud/phoenix)
Has been fixed via https://github.com/owncloud/core/pull/38415